Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
Integrated through reviewed implementation PR #362, merged as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
The frozen revision-2 union policy rejects a contract when one wire value can decode as different types. This draft adds a pairwise check during pure callable compilation.
The regression covers bytes markers, legacy ndarray and Torch markers, nested unions, a located diagnostic, and an unknown generated return. It keeps disjoint records and int | float supported. The guard treats decoder-required fields separately from fields a legacy marker can omit.
Evidence and gate
Independent source review accepted b11dae6. Full CI run 35505214309 passed at that head. The final 9e87968 commit changes only Prettier formatting, and the pinned formatter passes. An earlier run at 88859e2 failed one same-run data-plane overhead check (3.74x versus 3.5x); the later full run passed, and this branch changes no data-plane source.
This remains a draft core correction for #345. It does not include revision-3 exact integer work. A separate merge candidate combines both histories for independent conflict review and combined exact-head CI. No merge, release, or issue closure is requested.