Repository navigation
Conversation
Signed-off-by: Hitanshu Paruthi <hitanshu@squareup.com>
Signed-off-by: Hitanshu Paruthi <hitanshu@squareup.com>
|
🤖 @codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7cd1350f8b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Hitanshu Paruthi <hitanshu@squareup.com>
|
🤖 @codex review The latest commit adds browser coverage for the prior finding's exact light-Magenta selected-DM scenario. It passes in Chromium and WebKit with the pre-existing paired-ink override; temporarily replacing that override with pink makes the test fail. I replied with source and runtime evidence in the original thread and resolved it. No production styling changed in this follow-up. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Why are we making this change?
Unread threads and messages in Activity and the channel/DM sidebar currently use neutral dots that are easy to overlook. Consistent pink dots make unread activity easier to spot, similar to Slack.
What changed
Activity's existing
MessageListRowand the sidebar'sUnreadBadgecomposition use a dedicatedstatus-unreadcolor: magenta in light mode and a lighter pink in dark mode. Existing visibility, read-state behavior, text styling and row backgrounds stay with their current owners. Selected sidebar rows retain the contrast ink paired with their accent fill. The shared token registry and contrast checks cover the new role on resting, hovered and selected panel surfaces.Validation
sq agents reviewcompleted on the combined Activity/sidebar change with no findings.fac81077ewith no findings. The prior selected-dot comment was answered inline with source and runtime evidence and resolved.Screenshots
Before/after light and after dark screenshots were captured with synthetic fixture data in the real app. GitHub CLI refuses attachments to this upstream repository because this account has read-only access; screenshot attachment remains pending a maintainer. No live community content was uploaded.
Manual check
Open Activity with an unread thread or DM in light and dark mode. Its unread dot should be pink, as should unread channel activity and DM dots in the sidebar. Open or mark the conversation read: its dot disappears according to the existing read behavior. Mark it unread again: the dot returns wherever it was previously shown.
buzz-review-completed