Skip to content

Support character data assignment - #56

Merged
cowboyd merged 1 commit into
mainfrom
dom-character-data
Nov 11, 2026
Merged

cowboyd merged 1 commit into
mainfrom
dom-character-data

Conversation

@cowboyd

@cowboyd cowboyd commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Normalize Text and Comment data assignments to strings, treating null as an empty string, and make nodeValue and textContent writable through the same data setter.

Type of change

  • Bug fix
  • Feature
  • Refactor (no behavior change)
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • All tests pass (pnpm test)
  • Files are formatted (pnpm format)
  • I have added/updated tests for my changes (if applicable)
  • I have added a changeset

AI-generated code disclosure

  • This PR includes AI-generated code

@pkg-pr-new

pkg-pr-new Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/bombshell-dev/ui/@clack/ui@56

commit: 89d7f2c

@cowboyd
cowboyd added this pull request to stack #57 November 11, 2026 13:40
@cowboyd
cowboyd marked this pull request as ready for review November 11, 2026 13:42
@codspeed

codspeed Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Merging this PR will improve performance by ×2.6

⚡ 1 improved benchmark
✅ 239 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Memory grass (500) 682.2 KB 262.4 KB ×2.6

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing dom-character-data (89d7f2c) with main (ed10c9f)

Open in CodSpeed

Base automatically changed from dom-basic-creation to main November 11, 2026 17:38
@cowboyd
cowboyd merged commit aa3e927 into main Nov 11, 2026
9 checks passed
@cowboyd
cowboyd deleted the dom-character-data branch November 11, 2026 17:44
cowboyd added a commit that referenced this pull request Nov 11, 2026
## What does this PR do?

Track parentNode and parentElement while inserting, moving, and removing
child nodes. Route appendChild through insertBefore and enable four WPT
cases covering detached parent relationships, invalid anchors, and
insertion before self. Stacked on #56.

## Type of change

- [ ] Bug fix
- [x] Feature
- [ ] Refactor (no behavior change)
- [ ] Documentation
- [ ] Performance improvement
- [ ] Tests
- [ ] Chore (dependencies, CI, tooling)

## Checklist

- [x] All tests pass (`pnpm test`)
- [x] Files are formatted (`pnpm format`)
- [x] I have added/updated tests for my changes (if applicable)
- [x] I have added a changeset

## AI-generated code disclosure

- [ ] This PR includes AI-generated code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants