Repository navigation
Support character data assignment - #56
Merged
Merged
Conversation
commit: |
cowboyd
marked this pull request as ready for review
November 11, 2026 13:42
cowboyd
force-pushed
the
dom-character-data
branch
from
November 11, 2026 15:03
8aec1b0 to
a99e9a4
Compare
5 of 12 tasks
natemoo-re
approved these changes
Nov 11, 2026
cowboyd
force-pushed
the
dom-character-data
branch
from
November 11, 2026 17:06
a99e9a4 to
6ad41bf
Compare
Merging this PR will improve performance by ×2.6
Performance Changes
Tip Curious why performance improved? Comment Comparing |
cowboyd
force-pushed
the
dom-character-data
branch
from
November 11, 2026 17:38
6ad41bf to
89d7f2c
Compare
cowboyd
added a commit
that referenced
this pull request
Nov 11, 2026
## What does this PR do? Track parentNode and parentElement while inserting, moving, and removing child nodes. Route appendChild through insertBefore and enable four WPT cases covering detached parent relationships, invalid anchors, and insertion before self. Stacked on #56. ## Type of change - [ ] Bug fix - [x] Feature - [ ] Refactor (no behavior change) - [ ] Documentation - [ ] Performance improvement - [ ] Tests - [ ] Chore (dependencies, CI, tooling) ## Checklist - [x] All tests pass (`pnpm test`) - [x] Files are formatted (`pnpm format`) - [x] I have added/updated tests for my changes (if applicable) - [x] I have added a changeset ## AI-generated code disclosure - [ ] This PR includes AI-generated code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Normalize Text and Comment
dataassignments to strings, treatingnullas an empty string, and makenodeValueandtextContentwritable through the same data setter.Type of change
Checklist
pnpm test)pnpm format)AI-generated code disclosure