Skip to content

Support node removal - #62

Merged
cowboyd merged 1 commit into
mainfrom
wpt-child-node-remove
Nov 12, 2026
Merged

cowboyd merged 1 commit into
mainfrom
wpt-child-node-remove

Conversation

@cowboyd

@cowboyd cowboyd commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Preact requires Node.remove()

Add remove() to detach nodes through the existing removeChild() implementation, with a no-op for detached nodes. Unfortunately, to use the WPT test for CharacterData, it requires a processing-instruction node because that's what the test cases use.

I opted to implement it (it's tiny) rather than fork the WPT test or use a one-off test.

Type of change

  • Bug fix
  • Feature
  • Refactor (no behavior change)
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • All tests pass (pnpm test)
  • Files are formatted (pnpm format)
  • I have added/updated tests for my changes (if applicable)
  • I have added a changeset

AI-generated code disclosure

  • This PR includes AI-generated code

@cowboyd cowboyd changed the title Support node removal and processing instructions Support node removal Nov 11, 2026
@pkg-pr-new

pkg-pr-new Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/bombshell-dev/ui/@clack/ui@62

commit: fc84090

@cowboyd
cowboyd added this pull request to stack #63 November 11, 2026 20:06
@cowboyd
cowboyd marked this pull request as ready for review November 11, 2026 20:06
@cowboyd cowboyd mentioned this pull request Nov 11, 2026
6 of 12 tasks

@natemoo-re natemoo-re left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Base automatically changed from wpt-stable-registry-aliases to main November 12, 2026 21:16
@cowboyd
cowboyd force-pushed the wpt-child-node-remove branch from 10ab864 to fc84090 Compare November 12, 2026 21:16
@cowboyd
cowboyd merged commit bd069ea into main Nov 12, 2026
7 of 9 checks passed
@cowboyd
cowboyd deleted the wpt-child-node-remove branch November 12, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants