Repository navigation
Fix weakness to host header manipulation - #1121
Merged
Merged
Conversation
For a long time we used `HTTP_HOST` as a fallback for `fullBaseUrl`, but doing so makes applications vulnerable to host header injection. In #1071, the `HostHeaderMiddleware` was introduced to address this weakness. However, in #1076 the debug condition was removed to address feedback, but also re-opened the weakness to host-header injection. These changes restore the `debug` check around automatically trusting `HTTP_HOST`. The `HostHeaderMiddleware` is applied *after* error handling so configuration mistakes are easy to identify. Thanks to Jaro Varga for reporting this.
ADmad
approved these changes
Nov 8, 2026
josbeir
reviewed
Nov 8, 2026
| $s = null; | ||
| if (env('HTTPS') || env('HTTP_X_FORWARDED_PROTO') === 'https') { | ||
| $s = 's'; | ||
| if (Configure::read('debug')) { |
Contributor
There was a problem hiding this comment.
I'm no fan of that $s variable.
Wouldn't something like this be more readable ? 🤖
$fullBaseUrl = Configure::read('App.fullBaseUrl');
if (!$fullBaseUrl && Configure::read('debug')) {
$httpHost = env('HTTP_HOST');
if ($httpHost) {
$scheme = (
env('HTTPS') || env('HTTP_X_FORWARDED_PROTO') === 'https'
) ? 'https' : 'http';
$fullBaseUrl = $scheme . '://' . $httpHost;
}
unset($httpHost, $scheme);
}
if ($fullBaseUrl) {
Router::fullBaseUrl($fullBaseUrl);
}
unset($fullBaseUrl);
Member
|
With josbeir's improvement I'd say this looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a long time we used
HTTP_HOSTas a fallback forfullBaseUrl, but doing so makes applications vulnerable to host header injection. In #1071, theHostHeaderMiddlewarewas introduced to address this weakness. However, in #1076 the debug condition was removed to address feedback, but also re-opened the weakness to host-header injection.These changes restore the
debugcheck around automatically trustingHTTP_HOST. TheHostHeaderMiddlewareis applied after error handling so configuration mistakes are easy to identify.Thanks to Jaro Varga for reporting this.