Skip to content

Fix weakness to host header manipulation #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markstory merged 2 commits into from
Nov 9, 2026
+7 −8
Merged

Fix weakness to host header manipulation #1121

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f25d4e
Fix weakness to host header manipulation
markstory Nov 4, 2026
7fb4cb0
Simplify logic to create scheme
markstory Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions config/bootstrap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
use Cake\Datasource\ConnectionManager;
use Cake\Error\ErrorTrap;
use Cake\Error\ExceptionTrap;
use Cake\Http\Exception\ForbiddenException;
use Cake\Http\ServerRequest;
use Cake\Log\Log;
use Cake\Mailer\Mailer;
Expand Down Expand Up @@ -165,21 +166,19 @@
*/
$fullBaseUrl = Configure::read('App.fullBaseUrl');
if (!$fullBaseUrl) {
$httpHost = env('HTTP_HOST');

/*
* Development mode fallback: Use HTTP_HOST for convenience.
* WARNING: This is ONLY safe in development. In production, the
* HostHeaderMiddleware will reject requests when fullBaseUrl is not configured.
*/
if ($httpHost) {
$s = null;
if (env('HTTPS') || env('HTTP_X_FORWARDED_PROTO') === 'https') {
$s = 's';
if (Configure::read('debug')) {

@josbeir josbeir Nov 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm no fan of that $s variable.

Wouldn't something like this be more readable ? 🤖

$fullBaseUrl = Configure::read('App.fullBaseUrl');

if (!$fullBaseUrl && Configure::read('debug')) {
    $httpHost = env('HTTP_HOST');
    if ($httpHost) {
        $scheme = (
            env('HTTPS') || env('HTTP_X_FORWARDED_PROTO') === 'https'
        ) ? 'https' : 'http';

        $fullBaseUrl = $scheme . '://' . $httpHost;
    }
    unset($httpHost, $scheme);
}

if ($fullBaseUrl) {
    Router::fullBaseUrl($fullBaseUrl);
}
unset($fullBaseUrl);

@markstory markstory Nov 9, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

$httpHost = env('HTTP_HOST');
if ($httpHost) {
$scheme = env('HTTPS') || env('HTTP_X_FORWARDED_PROTO') === 'https' ? 'https' : 'http';
$fullBaseUrl = $scheme . '://' . $httpHost;
}
$fullBaseUrl = 'http' . $s . '://' . $httpHost;
unset($httpHost, $scheme);
}
unset($httpHost, $s);
}
if ($fullBaseUrl) {
Router::fullBaseUrl($fullBaseUrl);
Expand Down