Skip to content

ci: add a separate 0.22 nightly channel - #4545

Merged
thymikee merged 12 commits into
mainfrom
chore/nightly-022-release-config
Nov 16, 2026
Merged

thymikee merged 12 commits into
mainfrom
chore/nightly-022-release-config

Conversation

@thymikee

@thymikee thymikee commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

Summary

Add an internal 0.22 nightly at 01:53 UTC through main’s trusted release workflow. Main’s 01:23 nightly and stable/latest behavior remain unchanged. Manual runs use source_branch=0.22; packages use nightly-0.22.

The final diff contains 9 release-tooling/test/contributor files, 748 gross lines. There are no product-code or public installation-guide changes. #4588 separately removes the updater special case already integrated into 0.22.

Before upload, a signed attestation binds each tarball digest to its planned source repository/ref/commit/version. Verification pins main’s release workflow and an independently obtained workflow commit. Signing failure prevents publication. npm’s own provenance still names the main workflow context; the additional signature identifies the actual build source.

Validation

Head: 1d9662799053fc4067ccdbbf8e601f55843b0db5.

Pinned pnpm 11.17.0 frozen install/build/full-repository format passed. Exact-head affected validation: 42 passed, 25 skipped, exactCommit=true, checkoutChanged=false. Receipt SHA256: d5ad0e4888d22eb88e9f92fe1a958b122a7589bdbd8fa231e0a10f3e29db4a19. Source/logical index stayed unchanged; physical-index changes and unrelated ref movements remain qualified evidence.

The workflow guard failed before repair and passed afterward. Independent source review/recheck found no actionable findings. New-head hosted checks are pending; prior 9833a36 had 23 successful/10 skipped checks. Maintainer-approved false-positive dismissals cover exactly CodeQL alerts 68–71.

Real attestation/OIDC execution remains unrun. No merge, activation, release or package publication has occurred. Private-plugin publication remains separate.

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 6.28 MB 6.28 MB 0 B
Package (unpacked) 6.28 MB 6.28 MB 0 B
Package (download) 1.90 MB 1.90 MB -7 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 26.7 ms 26.3 ms -0.4 ms
CLI --help 54.2 ms 61.4 ms +7.2 ms

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 12 files

You’re at about 90% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread scripts/release-version.mjs Resolved
Comment thread scripts/release-plan.mjs Resolved
@apex-sentinel-staging

apex-sentinel-staging Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Apex Sentinel · 🟠 Request changes

Since the last review: 2 new · 0 still open · 1 no longer raised

2 finding(s): 2 major.

Required fixes

  • 0.22 build executes the 0.22 branch's own actions and scripts inside the main-owned trusted run
  • create-storage-record: 'false' discards the nightly source attestation; it is never stored or verifiable

🟠 Major (2)

Where Finding
.github/workflows/release.yml:107 🆕 0.22 build executes the 0.22 branch's own actions and scripts inside the main-owned trusted run
.github/workflows/release.yml:173 🆕 create-storage-record: 'false' discards the nightly source attestation; it is never stored or verifiable

Reviewed with this repository's own Sentinel configuration (36dbd2616fc6).

💬 Talking to Sentinel

In a finding's thread, reply with:

Command What it does
@apex-sentinel-staging note <context> Adds context; Sentinel re-checks the cited code
@apex-sentinel-staging pivot <why> Says the finding is wrong; Sentinel re-checks the cited code
@apex-sentinel-staging like Marks the finding as useful
@apex-sentinel-staging dislike <why> Marks it as not useful, so it is not raised again

On this conversation, comment @apex-sentinel-staging review to run a full review once again.

Earlier reviews

Review of 9833a360 · 16.11.2026 08:17 UTC

Apex Sentinel · ✅ Approve

Since the last review: 1 new · 0 still open · 1 no longer raised

1 finding(s): 1 minor.

🟡 Minor (1)

Where Finding
.github/workflows/release.yml:91 🆕 Publishing 0.22 sources from a main run bypasses the main-only deployment protection

1 finding below minor hidden (user_settings.min_severity).

Reviewed with this repository's own Sentinel configuration (189570486a11).

Review of 48bad166 · 14.11.2026 16:06 UTC

Apex Sentinel · ✅ Approve

Since the last review: 1 new · 0 still open · 1 no longer raised

1 finding(s): 1 minor.

🟡 Minor (1)

Where Finding
scripts/release-plan.mjs:365 🆕 PR dry-run now builds the PR head commit instead of the merge ref

Reviewed with this repository's own Sentinel configuration (d78be6c88715).

Review of ae654e8b · 14.11.2026 13:01 UTC

Apex Sentinel · 🟠 Request changes

Since the last review: 0 new · 1 still open · 0 no longer raised

1 finding(s): 1 major.

Required fixes

  • 0.22 nightlies stop the moment main's stable release passes 0.22.0

🟠 Major (1)

Where Finding
scripts/release-plan.mjs:52 0.22 nightlies stop the moment main's stable release passes 0.22.0

1 finding below minor hidden (user_settings.min_severity).

1 new finding away from what changed since 3ea1e40 not shown. Comment @apex-sentinel-staging review for a full review.

Reviewed with this repository's own Sentinel configuration (d78be6c88715).

Review of 3ea1e405 · 14.11.2026 12:41 UTC

Apex Sentinel · ✅ Approve

1 finding(s): 1 minor.

🟡 Minor (1)

Where Finding
scripts/release-plan.mjs:156 assertAheadOfStable rejects a 0.22 nightly while main holds that release

1 finding below minor hidden (user_settings.min_severity).

Reviewed with this repository's own Sentinel configuration (d78be6c88715).

@apex-sentinel-staging apex-sentinel-staging Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apex Sentinel: 1 new finding on 3ea1e40. The verdict and the full list are in the summary comment.

@apex-sentinel-staging apex-sentinel-staging Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apex Sentinel: 1 finding moved to a new line on ae654e8. The verdict and the full list are in the summary comment.

Comment thread scripts/release-plan.mjs Resolved
@thymikee

Copy link
Copy Markdown
Member Author

I found two problems at ae654e8 that need a fix before this can merge.

The 0.22 nightly is published by npm publish --provenance inside a run whose ref is refs/heads/main and whose SHA is main's HEAD (release.yml#L168, release-publish.mjs#L68). npm builds the provenance statement from that runner context, but the tarballs were built from the 0.22 commit. So each nightly-0.22 package would carry a signed attestation that names a main commit whose sources and version (0.21.x-dev) are not the published bytes. Users who trace a package to source through npm provenance would land on the wrong commit; only the nightly-0.22/v<version> tag records the real source. I did not inspect a published attestation, since no 0.22 nightly exists yet. This follows from npm's documented use of the GitHub runner context. The rule the code must satisfy: the provenance source commit names the commit the bytes were built from. Either publish the 0.22 channel from a run whose ref and SHA are the 0.22 commit, which needs npm-publish and trusted-publisher access for 0.22, or accept the limitation. To accept it, say in the CONTRIBUTING activation section and in the tag-nightly step summary that nightly-0.22 provenance names main's workflow commit and that the tag names the source, and get maintainer sign-off before activation.

assertAheadOfStable still applies to the 0.22 source (release-plan.mjs#L56). Once stable reaches 0.22.0 or later, scheduled 0.22 nightlies fail and manual ones throw. The fix in e9d4741 is not pushed at this head. Please push it, keeping the guard for main only and keeping the 0.22.X-dev and exact push-CI checks.

Not blocking, and you can take or leave these: (1) cache-mode: none is enforced by GitHub's cache service, but the build runs on a Blacksmith macOS runner whose docs describe a colocated cache and do not mention cache-mode, so code from the planned 0.22 checkout may still write entries that main restores; run the build on a GitHub-hosted macOS runner, or show that an actions/cache save under cache-mode none is refused on blacksmith-6vcpu-macos-26, then dismiss the CodeQL alerts with that justification (release.yml#L83); (2) the source and tag rule is checked in both sourceBranchForRun and planRelease, so keep it in planRelease and let sourceBranchForRun only map the event to a source (release-plan.mjs#L24); (3) commits/0.22 accepts any ref name, so a tag named 0.22 could shadow the branch; resolve refs/heads/0.22 explicitly (release-plan.mjs#L294); (4) the test titled "the release build has no cache token access and restores no dependency cache" only asserts the YAML input cache-store: 'false', so retitle it to what it checks (release-workflow.test.ts#L50); (5) NIGHTLY accepts both suffixes under either tag prefix, which is hardening only because just the workflow writes these tags (release-version.mjs#L13).

Would one exported NIGHTLY_CHANNELS table in scripts/release-version.mjs be simpler? Each row would hold cron, dist tag, version suffix, tag prefix and dev-version pattern, for example main and 0.22. Then nightlyVersion, latestNightlyTag, NIGHTLY, the remote tag patterns, sourceBranchForRun and planNightly would read from it, validation would live once in planRelease, and the workflow test would assert that the crons, choice options and concurrency key in release.yml match the table. Adding or retiring a maintenance line would become a one-row change instead of edits at about 14 sites. The provenance decision above comes first: if 0.22 must publish from its own ref, the table would carry the ref and the run-on-main design changes shape.

CodeQL reports 4 high alerts, all on lines this PR adds or makes reachable: release.yml lines 107, 113 and 119, and setup-node-pnpm/action.yml line 73. They run after the new checkout of the planned commit and stay open until dismissed with a justification, since CodeQL does not model cache-mode. The other 31 checks pass, including the Release dry-run Plan and Build. There are no conflicts. I did not rerun the local suites, I did not review e9d4741, and I did not read prerequisite PR #4546 beyond its file list. I also could not see classic branch protection or org rulesets with the access I have, so I did not confirm that main and 0.22 have the same writers.

On the open threads: the one on the stable-version guard still applies and is the second problem above, and the one on tag suffix acceptance still applies as hardening (note 5). The thread on the daily cron firing twice does not apply: each cron fires once per UTC day, the unchanged-SHA skip covers a repeat, and a second same-day publish needs a manual workflow_dispatch, which CONTRIBUTING documents as publish now. Please resolve it.

Before merge, push e9d4741 and settle the provenance stance for nightly-0.22. Then either show that cache-mode: none is enforced on the Blacksmith macOS build runner or move the build to a GitHub-hosted runner, so the CodeQL alerts can be closed with evidence.

@thymikee

Copy link
Copy Markdown
Member Author

Verified local evidence for unpublished candidate 443d483, based on published ae654e8:

  • Fresh direct pnpm 11.17.0 frozen install/build: exit 0. The prior shell-hop setup failure remains invalid evidence; it ran no tests.
  • Exactly one RED with candidate tests and only release-plan.mjs + release-version.mjs replaced by AE654 bytes: 9 failed, 40 passed, exit 1. Failures cover the stable-version boundary, foreign channel suffixes, and selected npm-channel daily guard. The 0.22 subprocess case reaches the old stable blocker before its dedupe assertion; no isolated subprocess dedupe proof is claimed for that case.
  • Exactly one GREEN with original candidate bytes restored: 49 passed, exit 0. Identical argv/environment, two workers. The cron/concurrency guard passes in both phases; the old workflow already had that behavior.
  • Exactly once: pnpm check:affected --run --head 443d483. Raw exit 0; 42 passed / 25 skipped, 67 selected, FAIL-OPEN retained; exactCommit=true, checkoutChanged=false, clean matching fingerprint 25233167b22a00807f04098580a0ea870e63870d8e806cb42fab6e3109f5d456.
  • Gate UTC 2026-11-14 14:49:06.684–14:59:06.646, 599.957 seconds. No printed lock-wait messages; actual acquisition wait unmeasured. Default base/merge base remained main d78be6c.
  • Original/copied receipt bytes match SHA256 901339ddc9eed39ec08f2d13754f32d61d874f8677ccc88844c2f627c7a17e0f. All 141 evidence files verified in the directory and immutable archive; archive SHA256 53515d8f26cadc9425acea990baefaaf541001ac1504fe13120aa7d92bdb32a7.

Independent source/security delta recheck is still running; no new-head hosted/security or activation clearance follows from these local results. Current published AE654 CodeQL failure remains red. #4546 is now merged into 0.22 as 0081f61; successful ci.yml push CI at that exact SHA remains a separate activation requirement. No tags, publication, dispatch or external policy changes occurred.

@thymikee

Copy link
Copy Markdown
Member Author

Exact-head evidence for 48bad16:

  • Direct pnpm 11.17.0 frozen install/build: both exit 0.
  • One intended RED using the old ae654 planner/version-owner bytes with unchanged deterministic-clock candidate tests: 9 failed/40 passed, exit 1. Restore candidate; identical argv/environment, two workers: GREEN 49 passed, exit 0. This tests the runtime boundary fixes; it does not independently reproduce the old midnight test race.
  • One default-base affected invocation: exit 0, 42 local checks passed/25 skipped, FAIL-OPEN full selection, exactCommit=true, checkoutChanged=false. origin/main and merge base d78be6c. Receipt UTC 15:39:15.396–15:49:08.269 on 2026-11-14. Matching clean fingerprints 51880fc452d8948ed2b206680d9a728ee799718e68ba4949e210bf5736a7751f.
  • Parent independently verified all 147 SHA256 manifest entries in both evidence directory and immutable archive, original/copy receipt bytes, candidate runtime/test Git blobs, equal RED/GREEN argv/environment and final clean logical index. Receipt SHA256 a62ca3207ad431553eb544615c36f85fa72a13c156cdbf4924ff66afe90e193d; archive SHA256 5b0c0de74c55d837dc4824a1c800d26c9a58006fe184dc621b8b4ec217ebad15. No printed lock wait; actual wait unmeasured.
  • Independent Apex source/prose/test-design/security recheck found NO FINDINGS at this exact candidate, verifying the two low findings and documentation nit fixed. Planner/version runtime bytes match reviewed 443; follow-up is four files +18/-6.

Source prerequisite #4546 is integrated and exact resulting 0.22 push CI succeeded: https://github.com/callstack/agent-device/actions/runs/43607376172

New-head hosted/security admission remains pending. The four HIGH CodeQL failures at ae654 remain recorded; independent model-gap assessments do not suppress or waive them. No activation, npm publication, tag, dispatch or external policy change occurred.

@apex-sentinel-staging apex-sentinel-staging Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apex Sentinel: 1 new finding on 48bad16. The verdict and the full list are in the summary comment.

Comment thread scripts/release-plan.mjs Resolved
@thymikee

Copy link
Copy Markdown
Member Author

Thanks for the update. At 48bad16 the other reviewers' inline threads are addressed, but the nightly-0.22 provenance problem from the earlier review is still open, and so are the CodeQL alerts.

A nightly-0.22 run executes the publish job with GITHUB_REF=refs/heads/main and GITHUB_SHA set to main's workflow commit. release-publish.mjs runs npm publish --provenance, and npm builds the signed attestation from that runner context. The tarballs were built from the 0.22 commit (release.yml:95). So each nightly-0.22 package would carry a signed statement that names a main commit, not the commit the bytes came from, and anyone tracing a package through npm provenance lands on the wrong source. CONTRIBUTING.md:199-200 says merging activates the 01:53 schedule, so merge is when this ships. The rule the code must satisfy is that the provenance source commit names the commit the bytes were built from, or the gap is documented and signed off. Either publish nightly-0.22 from a run whose ref and SHA are the 0.22 commit (this needs npm-publish environment and trusted-publisher access for 0.22), or state in the CONTRIBUTING activation section and in the tag-nightly summary that the attestation names main's workflow commit and the nightly-0.22/v<version> tag names the source, with maintainer sign-off before merge.

CodeQL still fails with four HIGH cache-poisoning alerts, at release.yml lines 107, 113 and 119 and .github/actions/setup-node-pnpm/action.yml:73. They look related to this PR: the build job checks out the planned commit at release.yml:91-95 and then runs local actions and builds from the 0.22 source. This head only renames a step, so runs-on and cache-mode: none are unchanged and the alerts still apply. I did not capture a CodeQL excerpt for this head, and I did not verify how the Blacksmith macOS runner treats cache-mode: none. Please show that cache-mode: none blocks cache saves on that runner, or move the build to a GitHub-hosted runner, then dismiss the alerts with that justification.

Not blocking, and fine to take or leave: in a scheduled run, readRun waits for settled CI before the npm-day skip, which only needs latestNightly and today's date. For 0.22 with no push run yet, that means up to 40 x 30 s of polling before the skip, so reading latestNightly first and returning early would avoid it.

The PR now adds four more per-channel special cases: the nightlyDistTag ternary, the matchNightlyVersion suffix ternary, sourceBranch === 'main' around assertAheadOfStable, and the main-only latest read. Would one exported NIGHTLY_CHANNELS table in scripts/release-version.mjs, keyed by source (main, 0.22), be simpler? Each row would hold cron, distTag, versionSuffix, tagPrefix, devVersionPattern, guardsAgainstStable and allowsVersionOnlyCiFallback. nightlyVersion, matchNightlyVersion, latestNightlyTag, nightlyDistTag, the ls-remote patterns, sourceBranchForRun, readPublishedVersions, ciConclusion and planNightly would read the row, and release-workflow.test.ts would assert that the crons, choice options and concurrency key match the table. Adding or retiring a maintenance line would then be a one-row change. This was asked in the earlier review and is still unanswered. It depends on the provenance decision: if 0.22 must publish from its own ref, each row also carries the publishing ref.

The local suites and the RED/GREEN runs were not rerun here, and the 0.22 push CI run was not opened. I judged the planner changes from the diff against ae654e8.

For the other threads: matchNightlyVersion channel suffix, npm-day skip and assertAheadOfStable on main only are fixed at this head, so you can resolve them. The merge-commit build thread is benign: on pull_request GITHUB_SHA is the merge commit, so it builds the merge result, which is expected.

Before merge, please settle the nightly-0.22 provenance question and close the four CodeQL alerts with evidence.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files (changes from recent commits).

You’re at about 95% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="CONTRIBUTING.md">

<violation number="1" location="CONTRIBUTING.md:208">
P1: This channel publishes packages whose npm provenance attests `main` rather than the `0.22` commit that produced the tarballs. A source tag and run summary do not repair that provenance mismatch; publish from a workflow attested to the planned source SHA, or add an equivalent signed source-to-artifact attestation, before activating this channel.</violation>
</file>

Comment thread CONTRIBUTING.md Resolved

@apex-sentinel-staging apex-sentinel-staging Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apex Sentinel: 1 new finding on 9833a36. The verdict and the full list are in the summary comment.

Comment thread .github/workflows/release.yml Resolved
@thymikee

Copy link
Copy Markdown
Member Author

Thanks for the update. I reviewed 9833a36 against my earlier comment. I found no new code problems, and the three earlier threads on channel filtering, the daily skip and the stable-version guard are fixed at this commit. The PR is not ready to merge yet. CodeQL still fails on alerts 68-71 (poisonable-step) at release.yml:107,113,119 and setup-node-pnpm/action.yml:73, and these look related to the new checkout of the planned 0.22 commit at release.yml:95. Main has no such alerts. Before merge, please show evidence that cache-mode: none removes cache write access from every step that runs 0.22-sourced code, for example a GitHub doc link or a run log where a cache save step fails, and then dismiss alerts 68-71 with that reason. The PR and the test do not show those cache-mode: none semantics. A maintainer also still needs to accept the documented nightly-0.22 provenance gap, because --provenance in a main-ref run attests main's commit while the bytes come from 0.22. The open threads on that provenance gap still apply, and the maintainer sign-off closes it. These threads do not apply, so please resolve them: branch policy for id-token (only main's publisher holds id-token: write, and the residual is the same provenance trade-off), dry-run commit (withdrawn, the dry run builds the merge result as expected), nightly tag filter, daily skip and stable guard (all fixed at this head). Not blocking, and you can take or leave these: the rule for the build job should be that no step executing 0.22-sourced code holds cache write access, and the DIST_TAG = 'nightly-0.22' check at release.yml:188 adds one more channel literal beside the per-channel ternaries in release-version.mjs and release-plan.mjs, so a per-channel field in one table, emitted as a plan output, would avoid matching the dist-tag string in the workflow. Would one exported NIGHTLY_CHANNELS table in scripts/release-version.mjs, keyed by main and 0.22, be simpler? Each row would hold cron, distTag, versionSuffix, tagPrefix, devVersionPattern, guardsAgainstStable, allowsVersionOnlyCiFallback and publishesFromSourceRef, with the version helpers, planNightly and the summary reading the row, and release-workflow.test.ts asserting the crons, dispatch options and concurrency key match it. That would depend on the maintainer's provenance decision: if 0.22 must publish from its own ref, each row would also need the publishing ref and npm-publish environment access.

@thymikee

thymikee commented Nov 16, 2026 •

Copy link
Copy Markdown
Member Author

At 9833a360b38e3d1d280ecb4d9af6c25add4ba656, the requested cache-access evidence is GitHub’s official cache-mode documentation: job-level mode controls scoped cache-token access, and none permits neither restoring nor saving. The effective mode applies to the whole job, rather than only an individual cache action.

The build job sets cache-mode: none before checking out and executing the planned source, and runs on GitHub-hosted macos-26. Its local setup/build/stamp/pack steps are all inside that job. Plan and Publisher load their tools from github.workflow_sha; Publisher alone has OIDC permission. The existing guard requires none.

This supports a false-positive disposition for alerts 68–71; it is not a cache-save experiment or an alert dismissal. No alert has been changed. Maintainer disposition and acceptance of the documented main-workflow/0.22-source provenance distinction remain required before activation. Current hosted checks are 22 successful, 10 skipped, one failed CodeQL check; the release dry-run did not publish anything.

Owner disposition: the user approved dismissal of exactly alerts 68–71 as false positives. All four now read dismissed with the documented cache-token justification. The existing CodeQL check at 9833a36 changed to SUCCESS without a rerun. The provenance thread remains open while a signed source-to-artifact repair is prepared; no activation or release has occurred.

@thymikee

Copy link
Copy Markdown
Member Author

Thanks, that evidence answers the cache question: the build job sets cache-mode: none at job level before checking out and running the 0.22 source, and the GitHub docs say that mode allows neither restore nor save, so alerts 68-71 look like false positives. Two maintainer steps remain before this can merge: dismissing those alerts with that reason, and accepting the documented provenance distinction (main workflow attesting 0.22-sourced bytes).

@apex-sentinel-staging apex-sentinel-staging Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apex Sentinel: 2 new findings on 1d96627. The verdict and the full list are in the summary comment.

Comment thread .github/workflows/release.yml Resolved
Comment thread .github/workflows/release.yml Resolved
@thymikee

Copy link
Copy Markdown
Member Author

The code in 1d96627 is ready. The source attestation in release.yml now covers every tarball before publish, and CONTRIBUTING.md documents how to verify it, which fixes the provenance concern from the earlier review. No real attestation exists yet, so the gh attestation verify command is checked by reading only. The only check that is not passing is a review-gate check that follows two open threads on this diff, not a failing build or test job. Before merge, a maintainer still has to accept that npm provenance names main alongside the new signed source attestation.

Not blocking, and you can take or leave these: create-storage-record: 'false' at release.yml:173 does nothing, because actions/attest only reads it when push-to-registry is true, so you can drop it and its assertion at release-workflow.test.ts:111. Also, gh attestation verify --format json prints an array, so the path at CONTRIBUTING.md:229 needs a leading .[0] to work in jq.

The open inline threads from other reviewers do not apply, so you can resolve them. This one restates the build trust boundary we already accepted, since the 0.22 build job holds only contents: read and the publisher re-checks package names and the planned version. This one misreads create-storage-record, which only governs registry storage records, and the attestation is still stored and verifiable. This one is withdrawn and duplicates the accepted provenance trade-off, which the source attestation now covers. The provenance thread is fixed at this head.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Nov 16, 2026
@thymikee
thymikee merged commit cfe0850 into main Nov 16, 2026
29 of 30 checks passed
@thymikee
thymikee deleted the chore/nightly-022-release-config branch November 16, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant