Repository navigation
ci: add a separate 0.22 nightly channel - #4545
Conversation
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
All reported issues were addressed across 12 files
You’re at about 90% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Apex Sentinel · 🟠 Request changesSince the last review: 2 new · 0 still open · 1 no longer raised 2 finding(s): 2 major. Required fixes
🟠 Major (2)
Reviewed with this repository's own Sentinel configuration ( 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment Earlier reviewsReview of
|
| Where | Finding |
|---|---|
.github/workflows/release.yml:91 |
🆕 Publishing 0.22 sources from a main run bypasses the main-only deployment protection |
1 finding below minor hidden (user_settings.min_severity).
Reviewed with this repository's own Sentinel configuration (189570486a11).
Review of 48bad166 · 14.11.2026 16:06 UTC
Apex Sentinel · ✅ Approve
Since the last review: 1 new · 0 still open · 1 no longer raised
1 finding(s): 1 minor.
🟡 Minor (1)
| Where | Finding |
|---|---|
scripts/release-plan.mjs:365 |
🆕 PR dry-run now builds the PR head commit instead of the merge ref |
Reviewed with this repository's own Sentinel configuration (d78be6c88715).
Review of ae654e8b · 14.11.2026 13:01 UTC
Apex Sentinel · 🟠 Request changes
Since the last review: 0 new · 1 still open · 0 no longer raised
1 finding(s): 1 major.
Required fixes
- 0.22 nightlies stop the moment main's stable release passes 0.22.0
🟠 Major (1)
| Where | Finding |
|---|---|
scripts/release-plan.mjs:52 |
0.22 nightlies stop the moment main's stable release passes 0.22.0 |
1 finding below minor hidden (user_settings.min_severity).
1 new finding away from what changed since 3ea1e40 not shown. Comment @apex-sentinel-staging review for a full review.
Reviewed with this repository's own Sentinel configuration (d78be6c88715).
Review of 3ea1e405 · 14.11.2026 12:41 UTC
Apex Sentinel · ✅ Approve
1 finding(s): 1 minor.
🟡 Minor (1)
| Where | Finding |
|---|---|
scripts/release-plan.mjs:156 |
assertAheadOfStable rejects a 0.22 nightly while main holds that release |
1 finding below minor hidden (user_settings.min_severity).
Reviewed with this repository's own Sentinel configuration (d78be6c88715).
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on 3ea1e40. The verdict and the full list are in the summary comment.
There was a problem hiding this comment.
Apex Sentinel: 1 finding moved to a new line on ae654e8. The verdict and the full list are in the summary comment.
|
I found two problems at ae654e8 that need a fix before this can merge. The 0.22 nightly is published by
Not blocking, and you can take or leave these: (1) Would one exported CodeQL reports 4 high alerts, all on lines this PR adds or makes reachable: On the open threads: the one on the stable-version guard still applies and is the second problem above, and the one on tag suffix acceptance still applies as hardening (note 5). The thread on the daily cron firing twice does not apply: each cron fires once per UTC day, the unchanged-SHA skip covers a repeat, and a second same-day publish needs a manual Before merge, push e9d4741 and settle the provenance stance for nightly-0.22. Then either show that |
|
Verified local evidence for unpublished candidate 443d483, based on published ae654e8:
Independent source/security delta recheck is still running; no new-head hosted/security or activation clearance follows from these local results. Current published AE654 CodeQL failure remains red. #4546 is now merged into 0.22 as 0081f61; successful ci.yml push CI at that exact SHA remains a separate activation requirement. No tags, publication, dispatch or external policy changes occurred. |
|
Exact-head evidence for 48bad16:
Source prerequisite #4546 is integrated and exact resulting 0.22 push CI succeeded: https://github.com/callstack/agent-device/actions/runs/43607376172 New-head hosted/security admission remains pending. The four HIGH CodeQL failures at ae654 remain recorded; independent model-gap assessments do not suppress or waive them. No activation, npm publication, tag, dispatch or external policy change occurred. |
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on 48bad16. The verdict and the full list are in the summary comment.
|
Thanks for the update. At 48bad16 the other reviewers' inline threads are addressed, but the nightly-0.22 provenance problem from the earlier review is still open, and so are the CodeQL alerts. A nightly-0.22 run executes the publish job with CodeQL still fails with four HIGH cache-poisoning alerts, at release.yml lines 107, 113 and 119 and Not blocking, and fine to take or leave: in a scheduled run, readRun waits for settled CI before the npm-day skip, which only needs The PR now adds four more per-channel special cases: the The local suites and the RED/GREEN runs were not rerun here, and the 0.22 push CI run was not opened. I judged the planner changes from the diff against ae654e8. For the other threads: matchNightlyVersion channel suffix, npm-day skip and assertAheadOfStable on main only are fixed at this head, so you can resolve them. The merge-commit build thread is benign: on pull_request Before merge, please settle the nightly-0.22 provenance question and close the four CodeQL alerts with evidence. |
There was a problem hiding this comment.
1 issue found across 3 files (changes from recent commits).
You’re at about 95% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="CONTRIBUTING.md">
<violation number="1" location="CONTRIBUTING.md:208">
P1: This channel publishes packages whose npm provenance attests `main` rather than the `0.22` commit that produced the tarballs. A source tag and run summary do not repair that provenance mismatch; publish from a workflow attested to the planned source SHA, or add an equivalent signed source-to-artifact attestation, before activating this channel.</violation>
</file>
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on 9833a36. The verdict and the full list are in the summary comment.
|
Thanks for the update. I reviewed 9833a36 against my earlier comment. I found no new code problems, and the three earlier threads on channel filtering, the daily skip and the stable-version guard are fixed at this commit. The PR is not ready to merge yet. CodeQL still fails on alerts 68-71 (poisonable-step) at release.yml:107,113,119 and setup-node-pnpm/action.yml:73, and these look related to the new checkout of the planned 0.22 commit at release.yml:95. Main has no such alerts. Before merge, please show evidence that |
|
At The build job sets This supports a false-positive disposition for alerts 68–71; it is not a cache-save experiment or an alert dismissal. No alert has been changed. Maintainer disposition and acceptance of the documented main-workflow/0.22-source provenance distinction remain required before activation. Current hosted checks are 22 successful, 10 skipped, one failed CodeQL check; the release dry-run did not publish anything. Owner disposition: the user approved dismissal of exactly alerts 68–71 as false positives. All four now read dismissed with the documented cache-token justification. The existing CodeQL check at 9833a36 changed to SUCCESS without a rerun. The provenance thread remains open while a signed source-to-artifact repair is prepared; no activation or release has occurred. |
|
Thanks, that evidence answers the cache question: the build job sets |
There was a problem hiding this comment.
Apex Sentinel: 2 new findings on 1d96627. The verdict and the full list are in the summary comment.
|
The code in 1d96627 is ready. The source attestation in release.yml now covers every tarball before publish, and CONTRIBUTING.md documents how to verify it, which fixes the provenance concern from the earlier review. No real attestation exists yet, so the Not blocking, and you can take or leave these: The open inline threads from other reviewers do not apply, so you can resolve them. This one restates the build trust boundary we already accepted, since the 0.22 build job holds only |
Summary
Add an internal
0.22nightly at 01:53 UTC through main’s trusted release workflow. Main’s 01:23 nightly and stable/latest behavior remain unchanged. Manual runs usesource_branch=0.22; packages usenightly-0.22.The final diff contains 9 release-tooling/test/contributor files, 748 gross lines. There are no product-code or public installation-guide changes. #4588 separately removes the updater special case already integrated into
0.22.Before upload, a signed attestation binds each tarball digest to its planned source repository/ref/commit/version. Verification pins main’s release workflow and an independently obtained workflow commit. Signing failure prevents publication. npm’s own provenance still names the main workflow context; the additional signature identifies the actual build source.
Validation
Head:
1d9662799053fc4067ccdbbf8e601f55843b0db5.Pinned pnpm 11.17.0 frozen install/build/full-repository format passed. Exact-head affected validation: 42 passed, 25 skipped,
exactCommit=true,checkoutChanged=false. Receipt SHA256:d5ad0e4888d22eb88e9f92fe1a958b122a7589bdbd8fa231e0a10f3e29db4a19. Source/logical index stayed unchanged; physical-index changes and unrelated ref movements remain qualified evidence.The workflow guard failed before repair and passed afterward. Independent source review/recheck found no actionable findings. New-head hosted checks are pending; prior
9833a36had 23 successful/10 skipped checks. Maintainer-approved false-positive dismissals cover exactly CodeQL alerts 68–71.Real attestation/OIDC execution remains unrun. No merge, activation, release or package publication has occurred. Private-plugin publication remains separate.