Repository navigation
fix(cli): remove internal nightly update routing - #4588
Conversation
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
1 issue found across 2 files
You’re at about 96% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/cli/update-check.ts">
<violation number="1" location="src/cli/update-check.ts:173">
P2: This removes the `nightly-0.22` routing, but the public install docs still tell 0.22 nightly users that the update notice follows `nightly-0.22`. Update `website/docs/docs/installation.md` in this PR to remove that statement and the `@nightly-0.22` install instruction, or explain the intended path for those users.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
| function distTagFor(version: string): 'latest' | 'nightly' | 'nightly-0.22' { | ||
| if (version.includes('-nightly-0-22.')) return 'nightly-0.22'; | ||
| /** A nightly build follows the `nightly` dist-tag; every other build follows `latest`. */ | ||
| function distTagFor(version: string): 'latest' | 'nightly' { |
There was a problem hiding this comment.
P2: This removes the nightly-0.22 routing, but the public install docs still tell 0.22 nightly users that the update notice follows nightly-0.22. Update website/docs/docs/installation.md in this PR to remove that statement and the @nightly-0.22 install instruction, or explain the intended path for those users.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At src/cli/update-check.ts, line 173:
<comment>This removes the `nightly-0.22` routing, but the public install docs still tell 0.22 nightly users that the update notice follows `nightly-0.22`. Update `website/docs/docs/installation.md` in this PR to remove that statement and the `@nightly-0.22` install instruction, or explain the intended path for those users.</comment>
<file context>
@@ -169,9 +169,8 @@ function cachedDistTag(cache: UpdateCheckCache): string {
-function distTagFor(version: string): 'latest' | 'nightly' | 'nightly-0.22' {
- if (version.includes('-nightly-0-22.')) return 'nightly-0.22';
+/** A nightly build follows the `nightly` dist-tag; every other build follows `latest`. */
+function distTagFor(version: string): 'latest' | 'nightly' {
return version.includes('-nightly.') ? 'nightly' : 'latest';
}
</file context>
Apex Sentinel · ✅ ApproveSince the last review: 0 new · 0 still open · 1 no longer raised (1 marked fixed) No open findings. Reviewed with this repository's own Sentinel configuration ( 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment Earlier reviewsReview of
|
| Where | Finding |
|---|---|
src/cli/update-check.ts:172 |
distTagFor comment lies for -nightly-0-22. builds: they route to latest |
Reviewed with this repository's own Sentinel configuration (36dbd2616fc6).
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on 09b617a. The verdict and the full list are in the summary comment.
|
I reviewed 09b617a. The updater change looks right, but one user doc still promises a channel the updater no longer routes. website/docs/docs/installation.md:68 says the update notice follows the channel you installed, including Not blocking: the Open threads: the thread on the installation.md channel text still applies and is the same defect as above. The thread on the update-check.ts comment does not apply, because that file matches its pre-#4546 version and routing those builds to CI is green with 15 checks and none failing. There are no conflicts. Before merge, fix installation.md:68 and decide on lines 63-66. |
Remove the internal preview channel special case from CLI updates. Preserve the generic latest fallback and existing main-nightly behavior. Exact-head affected validation passed at 716dddd: 42 passed, 25 skipped; hosted checks: 13 successful, 1 skipped. No release or package publication.
Summary
Remove dedicated internal-nightly update routing, as requested. Versions outside the existing main-nightly pattern use the existing
latestfallback; this does not add channel-specific routing or suppress the generic update checker.This removes the special case integrated through #4546 and complements main-owned release automation in #4545. The actual
0.22layer changes 2 files, +1/−37 lines. The default-main range includes inherited integration work: 362 files, +7639/−3096 lines.The latest commit deletes a redundant private-function comment. Runtime statements and tests are unchanged from the previously reviewed head.
Validation
Head:
716ddddbbf902eee829a684d92961085a6cc057a; base:2408a3702d487c9bad93776eba5fd71383351e8f.Pinned pnpm 11.17.0 setup was retained from
09b617ain the same checkout. Full-repository format and new exact-head affected validation passed: 42 passed, 25 skipped,exactCommit=true,checkoutChanged=false. Receipt SHA256:958583a96a1b49367cba5c157e2fc338f197ce302d9080695500364d88ee4539.Independent source review covered behavior at
09b617a; the new delta is comment-only. Source/logical index stayed unchanged during validation. Physical-index changes remain qualified evidence. Skips remain CI-owned; new-head hosted checks are pending. Previous09b617ahad 14 successful/1 skipped checks.No device execution, release, package publication or merge is included.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.