Repository navigation
Conversation
Apex Sentinel · ✅ ApproveSince the last review: 0 new · 0 still open · 1 no longer raised (1 marked fixed) No open findings. Reviewed with this repository's own Sentinel configuration ( 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment Earlier reviewsReview of
|
| Where | Finding |
|---|---|
packages/command-runtime/src/commands/interaction/runtime/settle-adaptive-confirmation.ts:47 |
🆕 Adaptive exit settles replacements in the 0.5–0.8 retained band that neither rule catches |
Reviewed with this repository's own Sentinel configuration (a30accf38081).
Review of 74425371 · 16.11.2026 23:08 UTC
Apex Sentinel · ✅ Approve
Since the last review: 0 new · 0 still open · 0 no longer raised
No open findings.
1 new finding away from what changed since 8d80138 not shown. Comment @apex-sentinel-staging review for a full review.
Reviewed with this repository's own Sentinel configuration (a30accf38081).
Review of 8d801382 · 16.11.2026 21:37 UTC
Apex Sentinel · ✅ Approve
Since the last review: 0 new · 0 still open · 1 no longer raised (1 marked fixed)
No open findings.
1 new finding away from what changed since c423b99 not shown. Comment @apex-sentinel-staging review for a full review.
Reviewed with this repository's own Sentinel configuration (a30accf38081).
Review of c423b993 · 16.11.2026 21:25 UTC
Apex Sentinel · ✅ Approve
Since the last review: 1 new · 0 still open · 0 no longer raised
1 finding(s): 1 minor.
🟡 Minor (1)
| Where | Finding |
|---|---|
packages/command-runtime/src/commands/interaction/runtime/stable-capture.ts:285 |
🆕 floorInForce misses a confirmed broad replacement when the requested window already exceeds 1.5 s |
1 finding below minor hidden (user_settings.min_severity).
Reviewed with this repository's own Sentinel configuration (a30accf38081).
Review of 421179e5 · 16.11.2026 21:12 UTC
Apex Sentinel · ✅ Approve
Since the last review: 0 new · 0 still open · 0 no longer raised
No open findings.
1 finding below minor hidden (user_settings.min_severity).
Reviewed with this repository's own Sentinel configuration (b13b016e9bc1).
Review of 9492f880 · 16.11.2026 19:31 UTC
Apex Sentinel · ✅ Approve
Since the last review: 0 new · 0 still open · 2 no longer raised
No open findings.
Reviewed with this repository's own Sentinel configuration (ea414582b7fa).
Review of 3e048a7f · 16.11.2026 18:45 UTC
Apex Sentinel · ✅ Approve
2 finding(s): 2 minor.
🟡 Minor (2)
| Where | Finding |
|---|---|
packages/kernel/src/snapshot.ts:576 |
isBusyIndicatorNode adds a 'progressbar' role that showsFirstScreen used to allow |
packages/daemon/src/execution/interaction/internal/interaction-flags.ts:42 |
refFrameCurrent ignores an observation the daemon marked outdated, so adaptive settle fires early |
2 findings below minor hidden (user_settings.min_severity).
Reviewed with this repository's own Sentinel configuration (ea414582b7fa).
There was a problem hiding this comment.
Apex Sentinel: 2 new findings on 3e048a7. The verdict and the full list are in the summary comment.
|
I found one defect at 9492f88: with Repro by code reading: run The rule to satisfy: a baseline counts as fresh only if this action's own resolution captured it, or if the daemon reports the session observation current (frame active, frame tree and stored snapshot not outdated, no newer observation). Please apply that to every baseline candidate in Not blocking, and you can take or leave these: the outdated-frame tests in settle-adaptive-confirmation.test.ts:205 cover only a selector press, and the helper comment at lines 47-48 ('the stored tree is the fresh baseline') is the assumption above; Could one predicate replace those three? Keep the rule module as is, and have the daemon compute one fact, The two inline threads from the earlier review no longer apply, so please resolve them. The progressbar thread was withdrawn correctly: The live runs were at 3e048a7, and by diff the 9492f88 delta affects only flows after wait text. The defect comes from tracing Before merge, please make the |
Deep link agent-device-test-app://settle-lab. Each button starts one effect with a known final screen: an in-place counter, 500/800 ms delayed results, a fading overlay, two-stage transitions with and without a spinner, and a toast that precedes navigation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A capture that differs from a fresh pre-action baseline settles once one confirming capture ~110 ms later agrees with it. A disagreeing pair, a busy indicator, a producer or presented-surface change, the broad-replacement floor, a capture that holds both screens of a transition, or a baseline the action did not capture while the daemon reports the observation not current keep today's quiet window. The daemon enables it only when its host environment sets AGENT_DEVICE_SETTLE_ADAPTIVE=1; default off, no flag or output change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
9492f88 to
421179e
Compare
|
Fixed in 421179e, after a rebase onto main at b13b016. The branch is squashed into two commits: the runtime change and the test-app fixture. Defect. The daemon now computes one fact,
Fail/pass evidence for the new test,
Non-blocking notes, all taken:
Rebase conflict: one, in Measurements: the live runs were at 3e048a7. The measured paths are unchanged: iOS selector presses use the action capture; Android presses and CI: this is a draft, so CI may not run the main unit and integration lanes. I'll report what runs. |
Size Report
Startup median (7 runs, lower is better):
|
…and the loop under threshold Load the adaptive module only when a settle asks for it, fold one capture's quiet-window and early-exit decisions into observeStableCapture, and name the capture presentation. The wait command reuses the contracts DaemonWaitTarget instead of a copy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on c423b99. The verdict and the full list are in the summary comment.
…placement under any window The guard compared the required window with the requested one, so a requested window at or above the 1.5 s floor hid a confirmed broad replacement. The broad-transition confirmation now reports its latch, and the adaptive rule keys on that. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This PR is ready at 8d80138. Both earlier concerns are fixed: the confirmation now keys off the latch instead of The checks show 18 reported and none failing at 8d80138, and there are no conflicts. The earlier live runs were at 3e048a7, and the delta only touches the switch-on paths plus a loop refactor that reads as behavior-neutral with the switch off. Of the open inline threads, the freshness-check one and the observation-current one are fixed at this head, and you can resolve them. The first-screen progressbar one does not apply, because that check runs only for Apple sessions and Apple nodes never format to Nothing else blocks the prototype. Before the default can flip, the PR needs the ADR 0011 |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
All reported issues were addressed across 20 files
You’re at about 98% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
…an early exit held The adaptive early exit now keeps the quiet window when a capture reads another iOS system surface than the baseline, and the settle reports the quiet span its confirming pair held instead of the full window. Covers the adaptive switch on the press/click/longpress and generic routes, and the window fields surviving the opt-in branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ired timers Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on 7dad132. The verdict and the full list are in the summary comment.
…t judged a broad replacement A rootless read after a non-presented baseline fails the broad-transition gate, so the latch stays an open question that a later rooted capture can still confirm. The adaptive rule now asks the shared broad-replacement predicate against the baseline in that state and escalates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This PR is ready at 8142f91. The two earlier gaps are fixed: an unruled latch no longer exits early, and a surface-bundle change (including an iOS system surface) now disarms the early exit. CI is green, with 19 checks and none failing, and I found no code problems. No conflicts. Not blocking, and you can take or leave these: The inline threads on the press/click/longpress forwarding tests (#4611 (comment)), The PR-body measurement tables predate 5b81888 and 8142f91; those commits only add disarm conditions on the switch-on path, so they can only lengthen switch-on waits, but the tables were not re-measured at head. A device run would confirm that a real SafariViewService sheet capture carries |
Summary
This is a prototype of an adaptive short confirmation for
--settle, for review as is. It is off by default. It runs only when the daemon host environment setsAGENT_DEVICE_SETTLE_ADAPTIVE=1, which the daemon passes on asSettleParams.earlyExit: 'adaptive'. It adds no CLI flag and does not change the output shape. With the switch off, every path matches main; the loop refactor is behavior-neutral.Flipping the default is not part of this PR. It needs:
settleObservationguarantee;interaction-guarantees.tsmatrix cell;--settlehelp.The rule (
settle-adaptive-confirmation.ts):kernel);wait text, Android freshness reads).Deadlines, quality checks, private-AX recovery and diff output are unchanged.
The PR touches 20 files, including a test-only Settle lab fixture screen (
agent-device-test-app://settle-lab).Results
Each cell is N=15 (tab: 30), with 2.5 s post-checks (
diff snapshotagainst the stored settled tree) and blocks rotated across arms.3e048a7f7c.244d1ff683.iOS (iPhone 17 Pro sim,
snapshot -iframe, bridge producer, 300 ms window)Android (API 37 AVD, full
snapshotframe, helper, 500 ms window)Delayed effects with an immediate acknowledgement (re-measured at
7dad132c87after review). The Settle lab now shows a "Run N" marker as soon as an action starts, so these cells measure "acknowledgement now, result later". In the tables above, the delay500/delay800 rows measured "no change, then a late change".The early exit settles on the acknowledgement every time. Today's window still catches a 500 ms result on iOS, and most Android results.
Checkout flow (10 steps, 9 settled; N=15; p50/p95 total):
Which escalations mattered:
210c5b1f6f) ran without it. There, iOS stack pushes settled mid-transition: 9/15 and 14/15 wrong, versus 0/15 for off. With it, both match off.What the rule makes worse: an action that acknowledges immediately and finishes later (above) is always wrong with the switch on. Also, unmarked multi-stage effects go from often wrong to always wrong. These are the plain intermediate step, toast-then-navigate, and the fading overlay. Today's rule already misses them 8–15/15 times, as it does delay800.
Recommendation
Don't flip the default yet.
A default change would need these updates (none are in this PR):
settleObservationguarantee;interaction-guarantees.tsmatrix cell;--settlehelp and docs;settle-observation.test.ts;Validation
@reffreshness test fails on9492f88;quietMs: 2000) fails with thec423b99guard.Both pass at the head.
snapshot -ihides text, so Android uses full snapshots.9492f88, andobservationCurrentat421179e5d6) change only flows afterwait textor after a newer observation, which the benchmark never takes.8d80138216was green (18 checks). The unrelated wait-target dedupe moved to refactor(wait): type the wait command target with the contracts DaemonWaitTarget #4618.🤖 Generated with Claude Code