Skip to content

refactor(wait): type the wait command target with the contracts DaemonWaitTarget - #4618

Open
thymikee wants to merge 1 commit into
mainfrom
t3/wait-target-dedupe
Open

thymikee wants to merge 1 commit into
mainfrom
t3/wait-target-dedupe

Conversation

@thymikee

@thymikee thymikee commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Summary

WaitCommandOptions.target in command-runtime repeated the daemon surface's DaemonWaitTarget union line for line, and Fallow reported the copy as clone group dup:52af5926. This PR types the target with the contracts DaemonWaitTarget and moves the fuller replay-landmark (recordedLandmark) doc comment onto the contracts type. Types only, no behavior change.

Validation

  • Tested at 9847e0702e.
  • pnpm gate fallow: no issues in the 2 changed files; duplication metric 0 (was 1).
  • Typecheck passes. Layering guard OK.
  • Wait unit tests: 8 files, 73 tests pass.
  • CI owns the full lanes.

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

View guided diff Turn on auto-fix

…nWaitTarget

The command-runtime WaitCommandOptions.target repeated the daemon surface
union (fallow dup:52af5926). Reuse the contracts owner and keep the fuller
replay-landmark doc there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 6.33 MB 6.33 MB 0 B
Package (unpacked) 6.33 MB 6.33 MB 0 B
Package (download) 1.92 MB 1.92 MB +22 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 35.3 ms 33.9 ms -1.4 ms
CLI --help 64.8 ms 69.0 ms +4.2 ms

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

You’re at about 98% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.

View guided diff | Turn on auto-fix | Re-trigger cubic

@apex-sentinel-staging

Copy link
Copy Markdown

Apex Sentinel · ✅ Approve

No open findings.

Reviewed with this repository's own Sentinel configuration (a30accf38081).

💬 Talking to Sentinel

In a finding's thread, reply with:

Command What it does
@apex-sentinel-staging note <context> Adds context; Sentinel re-checks the cited code
@apex-sentinel-staging pivot <why> Says the finding is wrong; Sentinel re-checks the cited code
@apex-sentinel-staging like Marks the finding as useful
@apex-sentinel-staging dislike <why> Marks it as not useful, so it is not raised again

On this conversation, comment @apex-sentinel-staging review to run a full review once again.

@thymikee

Copy link
Copy Markdown
Member Author

This PR is ready at 9847e07: the wait command now uses the contracts DaemonWaitTarget with no behavior change, and all 20 checks pass. There are no conflicts, and nothing else needs to happen before merge.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Nov 16, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant