Repository navigation
feat(platform-android): add --extra-params to package:aar and publish-local:aar - #744
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
2 tasks done
hurali97
approved these changes
Nov 5, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build:androidandrun:androidalready accept--extra-paramsto pass extra arguments to Gradle, butpackage:aarandpublish-local:aardon't. That leaves no way to pass a project property (-Pfoo=bar) or any other Gradle flag when building or publishing an AAR. Projects that need one have to call./gradlewdirectly.This PR adds the same
--extra-params <string>option to both AAR commands:packageAarandpublishLocalAartake an optionalextraParamsarray, andrunGradleAarappends it after-x lint, the same wayrunGradledoes.plugin-brownfield-androidforwardsargs.extraParamsto both commands.@rock-js/platform-androidand@rock-js/plugin-brownfield-android.The new argument is optional, so existing callers of
packageAar,publishLocalAar,packageAarActionandpublishLocalAarActionbehave exactly as before.Use case
A brownfield project that publishes more than one AAR from the same Gradle build, for example a shared native core plus thin per-flavor AARs. A project property selects what the module builds. Today the AAR commands can't pass that property, so the project has to drop Rock for packaging.
Test plan
aar.test.ts:packageAarandpublishLocalAarspawn Gradle with the extra params appended, and both options parse the string into separate arguments.pluginBrownfieldAndroid.test.ts: the registeredpackage:aarandpublish-local:aaractions forwardextraParams.pnpm vitest runforplatform-android(aar) andplugin-brownfield-android; eslint and prettier are clean on the changed files.