Repository navigation
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 8 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Decision takenQuestion. What does a gateway say when it refuses a plain lease because every worker with the platform serves phones only? #1588's Outcome and the session decision say "the same message" as the worker. Interface I3 spells out a different first clause. Options, and what a user would see:
Taken: option 1. I3 is the spec's explicit interface, and it is accurate for a fleet. The code, the advice and the details stay identical to the worker's refusal, so only the first clause differs. The Tests line for B8 on #1599 now pins the wording. Reverting it means changing one string in Written by an agent. |
… tests pin the platform filter and the order of workers (#1599)
… and ADR 0084 state (#1599)
Review ledgerRound 1: 143a4a6 {"findings":[{"id":"R1","role":"code","class":"spec I3 message delivered differently","outcome":"fixed","path":"src/gateway/routing/serviceability.ts","round":"1","fix":"ee4dc82f19f4fa089bf71d53a3ae444cc92a7b8f"},{"id":"R2","role":"code","class":"testing 3","outcome":"fixed","path":"src/gateway/fleet-routing-phones-only.test.ts","round":"1","fix":"ee4dc82f19f4fa089bf71d53a3ae444cc92a7b8f"},{"id":"R3","role":"code","class":"testing 10","outcome":"fixed","path":"src/gateway/aggregate-catalog.test.ts","round":"1","fix":"ee4dc82f19f4fa089bf71d53a3ae444cc92a7b8f"},{"id":"R4","role":"claims","class":"why comment credits ADR with wording","outcome":"nonblocking","path":"src/gateway/routing/serviceability.ts","round":"fix-check"}]}Written by an agent. |
Review notesNot blocking, not verified. Each is one reviewer's claim.
Written by an agent. |
…ose virtualDevices is false (#1623) Closes #1598 ## Done when - [x] `pnpm test:changed` passes, with every Tests line above as a test. — B1 `config-platform-and-driver-settings.test.ts`; B2, B3, B6 (catalog.get) and B7 `dispatcher-virtual-devices-off.test.ts`; B6 (CLI) `index-catalog-components.test.ts`; B5 `create-leasing-virtual-devices-off-startup.test.ts`; B4 `create-leasing-warm-pool-virtual-devices-off.test.ts`; B10 `doctor-warm-pool-targets.test.ts`; `docs-manuals.test.ts` 13/13 after baeaf51. - [x] `pnpm check` passes, the protocol-bump check included: `max` is one above the value `main` holds when this lands (after #1595 and #1596). — protocol range is { min: 89, max: 93 } after the stack merge with main (`src/contract/protocol.ts:13`, d27a21a); the pre-push hooks passed. - [x] The website build passes: `pnpm --dir website install && pnpm --dir website build && node website/scripts/check-openapi.mjs`. — 92 pages built, `check-openapi: 45 operations, 12 tags: ok`. - [x] `docs/internal/EVENTS.md` and `reference/events.mdx` list `virtual-devices-off` as an initiator of `device.shutdown` and `device.deleted`. — read in both files. ### Status Implement: done (stack merge d27a21a) Review: fix-check passed after the stack merge (coordinator) Hardware: n/a Gate: waiting for the stack Next: CI on d27a21a; stays in stack #1592 → #1623 → #1657 ## Assumptions - Assumption: the doctor's config slice — `DoctorConfig` is narrowed with `Pick` to the two `virtualDevices` flags it reads, the smallest change. - Assumption: the startup delete's operation name — it logs as a cleanup ("Could not delete an idle device at start"), matching the existing startup steps. - Assumption: where the reserve is zeroed — in the warm-pool converger and in doctor through `reserveOnVirtualPlatforms`, not inside the policy view, so the policy stays pure. - Assumption: B6 is proved at two seams — `catalog.get` through the dispatcher and the CLI print through the CLI test, because the Tests line names both. ## Review Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 1 blocking, 1 fixed, 0 notes. Claims review: 1 blocking, 1 fixed, 0 notes. Rounds: 2. Tokens: 6.1M. Runs: 19. Cost USD: 9.1982. Agent seconds: 2924. Assessment: complete *Written by an agent.*
Closes #1599
Done when
pnpm test:changedpasses, with every Tests line above as a test. — B8src/gateway/fleet-routing-phones-only.test.ts(one phones-only worker, with an emulator worker, with a worker without the field, an iOS-only worker beside a phones-only Android worker, no models,--physical), B9src/gateway/aggregate-catalog.test.ts(both orders);src/gateway840/840 at ee4dc82; the only other failures aresrc/daemon/lease-files.test.tsandsrc/daemon/relay-gateway-files.e2e.test.ts, which the open flaky-test issue flaky: lease-files and relay-gateway-files tests answer 422 instead of 201 on a clean base #1613 names.pnpm checkpasses. — the pre-push hooks (fallow, protocol-bump, docs-surface, typecheck) passed on every push, the last at f8f66bb; CI green at f8f66bb.pnpm --dir website install && pnpm --dir website build && node website/scripts/check-openapi.mjs. — CI jobbuild(.github/workflows/website.yml: install,pnpm build,node scripts/check-openapi.mjs) passed at f8f66bb.Completion conditions (#1588)
android.virtualDevices: false, every plain Android lease in Examples answersUNKNOWN_MODELwith the phones-only message at once, and no emulator is created, booted or downloaded for it. —src/daemon/dispatcher-virtual-devices-off.test.ts, theit.eachover android and ios with the Examples' request shapes (feat(leasing): a worker serves only enrolled devices on a platform whose virtualDevices is false #1623).--physicallease is granted, waits and is refused exactly as on a worker without it. — same file, "serves a --physical lease as on any worker: granted, waiting, NO_CAPACITY with noWait, UNKNOWN_MODEL with no enrolled match" (feat(leasing): a worker serves only enrolled devices on a platform whose virtualDevices is false #1623).src/leasing/create-leasing-warm-pool-virtual-devices-off.test.ts(feat(leasing): a worker serves only enrolled devices on a platform whose virtualDevices is false #1623).simlock baseline list. —src/leasing/create-leasing-virtual-devices-off-startup.test.ts, which also assertsbaselines.list, the callbaseline listanswers from (feat(leasing): a worker serves only enrolled devices on a platform whose virtualDevices is false #1623).simlock catalogshows the phones-only line for that platform, andcatalog.getcarriesvirtualDevices: false. —src/cli/index-catalog-components.test.ts"prints the phones-only line…", and the dispatcher test'scatalog.getcase (feat(leasing): a worker serves only enrolled devices on a platform whose virtualDevices is false #1623).simlock doctorreports a configured Android warm target as unreachable becauseandroid.virtualDevicesis false. —src/core/doctor-warm-pool-targets.test.ts, B10 (feat(leasing): a worker serves only enrolled devices on a platform whose virtualDevices is false #1623).ios.virtualDevices: falsedoes the same for iOS. — the dispatcher test runs both platforms (it.each(["android", "ios"])), and its--physicaland catalog cases use iOS (feat(leasing): a worker serves only enrolled devices on a platform whose virtualDevices is false #1623).--physicalis routed to that worker. —src/gateway/fleet-routing-phones-only.test.ts(this PR).reference/configuration.mdx,using-devices/physical-devices.mdx,reference/errors.mdxandusing-devices/errors.mdx(feat(leasing): a worker serves only enrolled devices on a platform whose virtualDevices is false #1623), andgateway/routing.mdx(this PR).Status
Implement: done Review: round 2 + fix-checks passed (R1–R3 fixed, R4 note) Hardware: n/a Gate: waiting for the stack
Next: ADR 0084 to Accepted on this branch, then the gate on this PR for the stack #1592 → #1623 → #1657
Assumptions
none
Review
Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 3 blocking, 3 fixed, 0 notes. Claims review: 0 blocking, 0 fixed, 1 notes.
Rounds: 2. Tokens: 4.4M.
Runs: 17. Cost USD: 3.7725. Agent seconds: 1687.
Assessment: complete
Written by an agent.