Repository navigation
Expose bosh_meltdown Prometheus metric via Health Monitor API #2841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -65,6 +65,10 @@ module Bosh::Monitor::Plugins | |
| it 'should not start' do | ||
| expect(plugin.run).to be(false) | ||
| end | ||
|
|
||
| it 'registers the alert_tracker on the Bosh::Monitor module' do | ||
| expect(Bosh::Monitor.alert_tracker).to be_a(Bosh::Monitor::Plugins::ResurrectorHelper::AlertTracker) | ||
|
Comment on lines
+69
to
+70
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Construct the plugin in this example. This example never evaluates the lazy
|
||
| end | ||
| end | ||
|
|
||
| context 'when the reactor is running' do | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why use
.keys.each_with_objecthere when all the other methods just do.each do |name, deployment|?Seems like an unnecessary detour, let me know if I missed somethig here.