Remove volumes when removing container.#2378
Open
jbehley wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change resolves an issue, which occured with our codabench_worker using Podman. (Not sure if the same happens with Docker at some point)
The problem
Our worker stopped working after couple of weeks and it took some time to understand the root cause of the problem, since the worker got always stuck when creating the container. We only recognized after we investigated several options that
podman volume ls | wc -lresulted in 2047 entries, which was too close to a "threshold". As it turns out, thecreate_containerwas failing as podman could not create additional volumes and therefore our process was always running into an execution timeout.We could resolve the problem by removing all dangling volumes that have been created (
podman volumes rm --all). After that "cleaning", the worker is now operational again.The fix
Therefore, we propose the change to have
remove_containeralso remove the volumes via the optionv=True. In our tests, this helps to avoid the problem described above.