Skip to content

Remove volumes when removing container. #2378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbehley wants to merge 1 commit into
base: develop
Choose a base branch
from
+4 −4
Open

Remove volumes when removing container. #2378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions compute_worker/compute_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,7 +875,7 @@ async def _run_container_engine_cmd(self, container, kind):
await websocket.wait_closed()
except Exception as e:
logger.error(e)
client.remove_container(container, force=True)
client.remove_container(container, v=True, force=True)

logger.debug(f"Container {container.get('Id')} exited with status code : {str(return_Code['StatusCode'])}")

Expand All @@ -890,7 +890,7 @@ async def _run_container_engine_cmd(self, container, kind):
finally:
try:
# Last chance of removing container
client.remove_container(container.get("Id"), force=True)
client.remove_container(container.get("Id"), v=True, force=True)
except Exception:
pass

Expand Down Expand Up @@ -1311,7 +1311,7 @@ def start(self):
)
for container in containers_to_kill:
try:
client.remove_container(str(container), force=True)
client.remove_container(str(container), v=True, force=True)
except docker.errors.APIError as e:
logger.error(e)
except Exception as e:
Expand Down Expand Up @@ -1363,7 +1363,7 @@ def start(self):
containers_to_kill = self.program_container_name
try:
client.kill(containers_to_kill)
client.remove_container(containers_to_kill, force=True)
client.remove_container(containers_to_kill, v=True, force=True)
except docker.errors.APIError as e:
logger.error(e)
except Exception as e:
Expand Down