Repository navigation
fix: make npm run clean remove the build info files - #348
Conversation
|
@codex review |
|
@codex security review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
|
@codex security review |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d06ff66cc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Review record for the merge decision.
Generated with |
Why
npm run clean(andmise run clean) leaves the TypeScript build info files behind. The nextnpm run buildthen reads the stale build info,tscdecides there is nothing to emit, anddist/holds only the renderer assets thatcopy-renderer-assets.mjscopies, with nodist/cli/main.js.install-smokethen fails with "tarball pack is missing dist/cli/main.js". I hit this while I validated a dependency PR on top of the pnpm move (#176).The script was
rimraf coverage dist *.tsbuildinfo. rimraf 4 and later do not expand globs unless--globis passed. The shell does not expand*.tsbuildinfoeither, because both build info files are dotfiles:.tsconfig.tsbuildinfo(tsconfig.json) and.tsconfig.build.tsbuildinfo(tsconfig.build.json). So rimraf got the literal name*.tsbuildinfoand removed nothing.What changed
cleannames both files:rimraf coverage dist .tsconfig.tsbuildinfo .tsconfig.build.tsbuildinfo.test/unit/tools/clean-script.test.tsruns the realcleanscript in a temp folder holdingdist/,coverage/and everytsBuildInfoFilethat the two tsconfigs name, then asserts that all of them are gone and thatpackage.json,src/and a non-dotvisible.tsbuildinfoare kept. With main's script it fails on.tsconfig.tsbuildinfo.Validation
package.jsonand passes with this one.mise run --force cleanthenmise run --force buildleavesdist/cli/main.jsin place (on main, it is missing).mise run --forceofformat-check,lint,typecheck,test-unit(144 files, 2074 tests) andinstall-smoke: exit 0.Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:high