Repository navigation
Conversation
The bench-env image is cached per platform (type=gha, scope=buildkit_<platform>) and later jobs reuse it on other machines, but RocksDB compiles with -march=native when PORTABLE is unset (it ends up in make_config.mk). A db_bench built on a machine with AVX-512 therefore dies with SIGILL on a runner without it, before it prints a single line. That is the rocksdb:mi and rocksdb:ff failures in the current runs: the same cached binary is gone after 0.1 s with no output on some jobs, while others pass the test. PORTABLE=1 keeps the binary runnable wherever the cache delivers it, and the measured time no longer depends on which machine built the cache: locally fillrandom takes 10.0 s native and 10.2 s portable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bench-env image is cached per platform (
type=gha, scope=buildkit_<platform>) and later jobs reuse it on other machines, but RocksDB compiles with-march=nativewhen PORTABLE is unset (it ends up in make_config.mk). Adb_benchbuilt on a machine with AVX-512 therefore dies withSIGILLon a runner without it, before it prints a single line.PORTABLE=1 keeps the binary runnable wherever the cache delivers it, and the measured time no longer depends on which machine built the cache: locally
fillrandomtakes 10.0 s native and 10.2 s portable.