Skip to content

direct: Fix updating the apps after the Go SDK upgrade#5444

Merged
andrewnester merged 3 commits into
mainfrom
fix/app-compute-min-instances
Jun 4, 2026
Merged

direct: Fix updating the apps after the Go SDK upgrade#5444
andrewnester merged 3 commits into
mainfrom
fix/app-compute-min-instances

Conversation

@andrewnester
Copy link
Copy Markdown
Contributor

@andrewnester andrewnester commented Jun 4, 2026

Changes

Fix updating the apps after the Go SDK upgrade

Why

Go SDK upgrade introduced 2 new fields to apps update_mask, which do not work correctly and cause apps updates to fail

Tests

Acceptance test pass

    --- SKIP: TestAccept/bundle/resources/apps/update (0.00s)
    --- SKIP: TestAccept/bundle/undefined_resources (0.00s)
    --- PASS: TestAccept/bundle/resources/apps/lifecycle-started-terraform-error (0.00s)
        --- PASS: TestAccept/bundle/resources/apps/lifecycle-started-terraform-error/DATABRICKS_BUNDLE_ENGINE=terraform (6.22s)
    --- PASS: TestAccept/bundle/resources/apps/lifecycle-started-omitted (0.00s)
        --- PASS: TestAccept/bundle/resources/apps/lifecycle-started-omitted/DATABRICKS_BUNDLE_ENGINE=direct (180.07s)
    --- PASS: TestAccept/bundle/resources/apps/lifecycle-started-toggle (0.00s)
        --- PASS: TestAccept/bundle/resources/apps/lifecycle-started-toggle/DATABRICKS_BUNDLE_ENGINE=direct (180.84s)
    --- PASS: TestAccept/bundle/resources/apps/inline_config (0.00s)
        --- PASS: TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct (181.98s)
    --- PASS: TestAccept/bundle/resources/apps/lifecycle-started (0.00s)
        --- PASS: TestAccept/bundle/resources/apps/lifecycle-started/DATABRICKS_BUNDLE_ENGINE=direct (424.84s)
PASS
ok      github.com/databricks/cli/acceptance    442.607s

@andrewnester andrewnester requested review from denik and pietern June 4, 2026 12:56
@andrewnester andrewnester added this pull request to the merge queue Jun 4, 2026
@eng-dev-ecosystem-bot
Copy link
Copy Markdown
Collaborator

eng-dev-ecosystem-bot commented Jun 4, 2026

Commit: 7ba4a35

Run: 26954600683

Merged via the queue into main with commit 5104468 Jun 4, 2026
23 checks passed
@andrewnester andrewnester deleted the fix/app-compute-min-instances branch June 4, 2026 14:19
deco-sdk-tagging Bot added a commit that referenced this pull request Jun 4, 2026
@deco-sdk-tagging
[Release] Release v1.2.1
723895e 
## Release v1.2.1

### Bundles
* direct: Fix updating the apps after the Go SDK upgrade ([#5444](#5444))
@eng-dev-ecosystem-bot
Copy link
Copy Markdown
Collaborator

eng-dev-ecosystem-bot commented Jun 4, 2026

Commit: 5104468

Run: 26957762306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pietern pietern pietern approved these changes

@denik denik Awaiting requested review from denik

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewnester @eng-dev-ecosystem-bot @pietern