Skip to content

direct: Fix updating the apps after the Go SDK upgrade #5444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewnester merged 3 commits into from
Jun 4, 2026
Merged

direct: Fix updating the apps after the Go SDK upgrade #5444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47b5837
direct: Fix updating the apps after Go SDK upgrade
andrewnester Jun 4, 2026
5089eb7
next changelog
andrewnester Jun 4, 2026
7ba4a35
add ignore remote
andrewnester Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion NEXT_CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
# NEXT CHANGELOG

## Release v1.3.0
## Release v1.2.1

### Notable Changes

### CLI

### Bundles
* direct: Fix updating the apps after the Go SDK upgrade ([#5444](https://github.com/databricks/cli/pull/5444))

### Dependency updates

Expand Down
4 changes: 2 additions & 2 deletions acceptance/bundle/resources/apps/lifecycle-started/output.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ Deployment complete!
"description": "MY_APP_DESCRIPTION_2",
"name": "[UNIQUE_NAME]"
},
"update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_size,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations"
"update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_size,git_repository,telemetry_export_destinations"
}
}

Expand All @@ -117,7 +117,7 @@ Deployment complete!
"description": "MY_APP_DESCRIPTION_3",
"name": "[UNIQUE_NAME]"
},
"update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_size,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations"
"update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_size,git_repository,telemetry_export_destinations"
}
}
{
Expand Down
2 changes: 1 addition & 1 deletion acceptance/bundle/resources/apps/update/out.requests.direct.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"description": "MY_APP_DESCRIPTION",
"name": "myappname"
},
"update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_size,compute_min_instances,compute_max_instances,git_repository,telemetry_export_destinations"
"update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_size,git_repository,telemetry_export_destinations"
},
"method": "POST",
"path": "/api/2.0/apps/myappname/update"
Expand Down
4 changes: 2 additions & 2 deletions bundle/direct/dresources/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,8 @@ var UpdateMaskFields = []string{
"resources",
"user_api_scopes",
"compute_size",
"compute_min_instances",
"compute_max_instances",
// "compute_min_instances", // TODO: add back when update APIs correctly support it
// "compute_max_instances", // TODO: add back when update APIs correctly support it
"git_repository",
"telemetry_export_destinations",
}
Expand Down
4 changes: 4 additions & 0 deletions bundle/direct/dresources/resources.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,10 @@ resources:
ignore_remote_changes:
- field: space # This field is not yet supported by Update APIs but exposed in the API spec. TODO: fix when update APIs supports it.
reason: managed
- field: compute_min_instances # This field does not work correctly in update_mask but exposed in the API spec. TODO: add back when update APIs correctly support it
reason: managed
- field: compute_max_instances # This field does not work correctly in update_mask but exposed in the API spec. TODO: add back when update APIs correctly support it
reason: managed

secret_scopes:
backend_defaults:
Expand Down
Loading