Repository navigation
Translate the testing paths of pipelines and upload local test wheels - #7437
Conversation
|
Commit: Regression test reportSelected 4 changed tests (limit=20, 0 not selected) 8 tests: regression=8 unreleased=0 coverage=0 failing=0
TestAccept/bundle/environments/dependencies/DMS=: branch ✅ | main (0f6d067) ❌ | latest (v1.26.0) ❌main (0f6d067): latest (v1.26.0): same output as main (0f6d067) TestAccept/bundle/environments/dependencies/DMS=true: branch ✅ | main (0f6d067) ❌ | latest (v1.26.0) ❌main (0f6d067): latest (v1.26.0): same output as main (0f6d067) TestAccept/bundle/resources/pipelines/testing-dynamic-version/DMS=: branch ✅ | main (0f6d067) ❌ | latest (v1.26.0) ❌main (0f6d067): latest (v1.26.0): TestAccept/bundle/resources/pipelines/testing-dynamic-version/DMS=true: branch ✅ | main (0f6d067) ❌ | latest (v1.26.0) ❌main (0f6d067): latest (v1.26.0): TestAccept/bundle/resources/pipelines/testing-same-name-libraries/DMS=: branch ✅ | main (0f6d067) ❌ | latest (v1.26.0) ❌main (0f6d067): latest (v1.26.0): TestAccept/bundle/resources/pipelines/testing-same-name-libraries/DMS=true: branch ✅ | main (0f6d067) ❌ | latest (v1.26.0) ❌main (0f6d067): latest (v1.26.0): TestAccept/bundle/resources/pipelines/testing/DMS=: branch ✅ | main (0f6d067) ❌ | latest (v1.26.0) ❌main (0f6d067): latest (v1.26.0): TestAccept/bundle/resources/pipelines/testing/DMS=true: branch ✅ | main (0f6d067) ❌ | latest (v1.26.0) ❌main (0f6d067): latest (v1.26.0): |
✅ Integration test reportCommit: 393738d
Top 3 slowest tests (at least 2 minutes):
|
48e4a95 to
fd9fedb
Compare
fd9fedb to
b10a21e
Compare
b10a21e to
e5ff44c
Compare
| @@ -1,3 +1,4 @@ | |||
| title "Relative test paths resolve to the deployed workspace paths\n" | |||
| trace $CLI bundle validate -o json | jq .resources.pipelines.orders.testing | |||
There was a problem hiding this comment.
Could you add a bundle deploy here (RecordRequests is already on in test.toml) so we see the test wheel uploaded and ./dist/*.whl rewritten to its .internal path? This test only runs validate, so the wheel stays ./dist/*.whl in the output, and the same-name test fails before upload, so nothing in the goldens shows the upload the description talks about. If that has to wait for #7438, worth a note in the script.
| }, | ||
| // Test dependencies take the same forms as the pipeline's environment dependencies. | ||
| { | ||
| pattern: base.Append(dyn.Key("testing"), dyn.Key("environment"), dyn.Key("dependencies"), dyn.AnyIndex()), |
There was a problem hiding this comment.
nit: the four dependency entries now differ only in the path prefix. Maybe loop over the two locations (environment and testing.environment) so the modes and skip functions live in one place?
There was a problem hiding this comment.
Done in 2189384. The patterns are built in one loop over environment and testing.environment, and their order does not change.
e5ff44c to
858d4df
Compare
858d4df to
52dc912
Compare
2189384 to
1c74f67
Compare
1706c59 to
669ee9b
Compare
| @@ -0,0 +1,9 @@ | |||
| trap "rm -fr dist" EXIT | |||
| mkdir dist | |||
| cp $TESTDIR/../../../artifacts/whl_prebuilt_multiple/dist/lib/other_test_code-0.0.1-py3-none-any.whl dist | |||
There was a problem hiding this comment.
Please copy the file here to make the test independent.
There was a problem hiding this comment.
Done. The wheel is now checked in next to the test.
669ee9b to
e036701
Compare
Co-authored-by: Isaac <no-reply@databricks.com>
e036701 to
1872129
Compare
…ked in Co-authored-by: Isaac <no-reply@databricks.com>
1872129 to
393738d
Compare
❌ Integration test reportCommit: 73a2b68
1335 interesting tests: 1313 MISS, 13 FAIL, 6 PANIC, 3 KNOWN
Top 50 slowest tests (at least 2 minutes):
|
…oyed folder (databricks#7427) ## 🥞 Stacked PR - [**stack/pipelines-test-b1-editable-folder**](databricks#7427) [[Files changed](https://github.com/databricks/cli/pull/7427/files)] ← _this PR_ - [stack/pipelines-test-b3-testing-paths](databricks#7437) [[Files changed](https://github.com/databricks/cli/pull/7437/files)] - [stack/pipelines-test-j1-testing-sources](databricks#7429) [[Files changed](https://github.com/databricks/cli/pull/7429/files)] --------- - `databricks pipelines test` runs without an environment variable. Its help marks it Beta, so it stays unstable under the stability policy. - A run of all tests sends `test_options` as an empty object, so a workspace that does not support it returns a clear error. - The `pipelines test` acceptance bundles declare `testing`, since test runs need `testing.sources`. - When Start Update fails with `PIPELINE_TEST_NO_TEST_SOURCES` and the bundle sets `testing`, the error says to deploy first. - Adds the changelog entry for the command and the `testing` property. Tests: `TestNewStartTestUpdateRequest`, `TestWithDeployHint`; acceptance `pipelines/test/not-enabled`, `pipelines/test/no-test-sources`, `pipelines/databricks-cli-help`, and the `pipelines/test` goldens without the gate cases. This pull request and its description were written by Isaac. --------- Co-authored-by: Isaac <no-reply@databricks.com>
…#7429) ## 🥞 Stacked PR - [stack/pipelines-test-b1-editable-folder](databricks#7427) [[Files changed](https://github.com/databricks/cli/pull/7427/files)] - [stack/pipelines-test-b3-testing-paths](databricks#7437) [[Files changed](https://github.com/databricks/cli/pull/7437/files)] - [**stack/pipelines-test-j1-testing-sources**](databricks#7429) [[Files changed](https://github.com/databricks/cli/pull/7429/files)] ← _this PR_ --------- - `databricks pipelines test` runs without an environment variable. Its help marks it Beta, so it stays unstable under the stability policy. - A run of all tests sends `test_options` as an empty object, so a workspace that does not support it returns a clear error. - The `pipelines test` acceptance bundles declare `testing`, since test runs need `testing.sources`. - When Start Update fails with `PIPELINE_TEST_NO_TEST_SOURCES` and the bundle sets `testing`, the error says to deploy first. - Adds the changelog entry for the command and the `testing` property. Tests: `TestNewStartTestUpdateRequest`, `TestWithDeployHint`; acceptance `pipelines/test/not-enabled`, `pipelines/test/no-test-sources`, `pipelines/databricks-cli-help`, and the `pipelines/test` goldens without the gate cases. This pull request and its description were written by Isaac. --------- Co-authored-by: Isaac <no-reply@databricks.com>
🥞 Stacked PR
testingresolve to their deployed paths, and local test wheels upload like other libraries.dynamic_version, test dependencies use the patched wheel; extras such as[test]are kept.testingare affected.Tests: acceptance
bundle/resources/pipelines/testing(validate, and the deploy request with the uploaded wheel),testing-same-name-librariesandtesting-dynamic-version.This pull request and its description were written by Isaac.