Skip to content

[Test only] Verify automatic PR reviews - #7731

Draft
shreyas-goenka wants to merge 2 commits into
mainfrom
shreyas-goenka/cli-review-smoke-test
Draft

shreyas-goenka wants to merge 2 commits into
mainfrom
shreyas-goenka/cli-review-smoke-test

Conversation

@shreyas-goenka

@shreyas-goenka shreyas-goenka commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Test-only PR for the automatic CLI review workflow. Do not merge. Returned to draft after verification.

Both paths passed on 2026-11-17:

Test Result Runs
Mark the clean draft ready Bot posted Looks good to me — no issues found. as a COMMENT review on 41d6fd432a67043367177b0711bb4a1348ada35f CLI, backend
Push two isolated fixture bugs and comment /review Bot posted two native inline findings on a4089a213a4d2898d82a6884997fbd386b2f7045 CLI, backend

The deliberate bugs were both identified:

The arithmetic fixture is isolated from CLI runtime code and intentionally remains incorrect as test evidence. No changes from this PR should be merged.

@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: a4089a2

Run: 44174528237

Env 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux-2core-8gb 1 270 15 6:54
💚​ aws-windows-latest-4core-16gb 1 272 13 4:44
💚​ azure linux-2core-8gb 1 269 15 6:17
💚​ azure-windows-latest-4core-16gb 1 271 13 5:08
💚​ gcp linux-2core-8gb 1 270 15 6:27
💚​ gcp-windows-latest-4core-16gb 1 272 13 6:35
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
Top 3 slowest tests (at least 2 minutes):
duration env testname
3:55 aws-windows-latest-4core-16gb TestAccept
3:53 azure-windows-latest-4core-16gb TestAccept
3:34 gcp-windows-latest-4core-16gb TestAccept

@shreyas-goenka
shreyas-goenka marked this pull request as ready for review November 17, 2026 20:51
@shreyas-goenka
shreyas-goenka requested a review from a team as a code owner November 17, 2026 20:51
@shreyas-goenka
shreyas-goenka requested a review from denik November 17, 2026 20:51

@review-oss-bot review-oss-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me — no issues found.

@shreyas-goenka

Copy link
Copy Markdown
Contributor Author

/review

@review-oss-bot review-oss-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests cover these two helpers. Even for a smoke-test fixture, a small test_review_smoke_fixture.py next to the file would pin the contracts the docstrings promise and would have caught both issues below before the review.


def average(values: list[int]) -> float:
"""Return the arithmetic mean, or 0.0 when values is empty."""
return sum(values) / len(values)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing an empty list hits ZeroDivisionError here (len([]) is 0), yet the docstring promises 0.0 for that input. Guard the division or return early when not values.


def is_even(value: int) -> bool:
"""Return True when value is an even integer."""
return value % 2 == 1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

value % 2 == 1 is true for odd numbers, not even ones. Should this be value % 2 == 0?

@shreyas-goenka
shreyas-goenka marked this pull request as draft November 17, 2026 21:00

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants