Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/review-smoke-test.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Temporary PR review smoke test

This test-only change verifies automatic CLI PR reviews and a subsequent
`/review` request. Close the PR after verification; do not merge this file.
11 changes: 11 additions & 0 deletions .github/scripts/review_smoke_fixture.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
#!/usr/bin/env python3


def average(values: list[int]) -> float:
"""Return the arithmetic mean, or 0.0 when values is empty."""
return sum(values) / len(values)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing an empty list hits ZeroDivisionError here (len([]) is 0), yet the docstring promises 0.0 for that input. Guard the division or return early when not values.



def is_even(value: int) -> bool:
"""Return True when value is an even integer."""
return value % 2 == 1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

value % 2 == 1 is true for odd numbers, not even ones. Should this be value % 2 == 0?

Loading