Repository navigation
acc: suppress DMS history warnings caused by transport errors - #7748
Merged
Merged
Conversation
Deployment history recording is best effort. A dropped HTTP/2 stream, an unexpected EOF or the drain deadline only produces a warning, but that warning fails the DMS=true variant because it shares goldens with the plain run. Suppress only those transport-caused warnings. Errors the service returns are still compared. cloud: TestAccept/bundle/config-remote-sync/cli_defaults/DMS=true TestAccept/bundle/resources/dashboards/delete-trashed-out-of-band/DMS=true TestAccept/bundle/resources/secrets/basic/DMS=true Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
✅ Integration test reportCommit: 47a734d
Top 3 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
November 18, 2026 05:52
denik
requested review from
Sankalp-Mittal,
andrewnester,
rclarey and
shreyas-goenka
and removed request for
rclarey
November 18, 2026 05:53
Sankalp-Mittal
approved these changes
Nov 18, 2026
Sankalp-Mittal
left a comment
Contributor
There was a problem hiding this comment.
[AI Generated] Review by review-factory (Claude Fable 5.2 + Claude Opus 5.5, cross-verified). Only points the reviewers agreed on are posted.
No blocking or major issues found.
Add "Could not delete deployment history" to the suppressed warnings: deleteDeployment retries only IsTransient, so a stream reset during destroy still produced the warning. Name the drain budget as the source of "context deadline exceeded" in the comment. Add bundle/dms/suppress-transport-warnings, which echoes lines the pattern must suppress and lines it must keep. cloud: TestAccept/bundle/config-remote-sync/cli_defaults/DMS=true TestAccept/bundle/resources/secrets/basic/DMS=true Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 3 tests: regression=0 unreleased=0 coverage=3 failing=0
|
Sankalp-Mittal
left a comment
Contributor
There was a problem hiding this comment.
[AI Generated] Follow-up review by review-factory (Claude Fable 5.2 + Claude Opus 5.5, cross-verified). Only points the reviewers agreed on are posted.
No new issues found.
andrewnester
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
acceptance/bundle/test.tomlgets a newSuppressLines.warn_dms_transportpattern. It moves a deployment history warning to the test log when the cause is a transport error:stream error: stream ID N; INTERNAL_ERROR; received from peerunexpected EOFcontext deadline exceeded(the best-effort drain deadline)It covers the six best-effort warnings:
Failed to record/complete deployment history,Could not enable/record/read/delete deployment history.bundle/dms/suppress-transport-warningspins the pattern with lines it must suppress and lines it must keep.Why
With
DMS=true, the bundle suite records deployment history in every test and compares against the same goldens as the plain run. Recording is best effort, so the CLI only warns when a history call fails. When the server resets an HTTP/2 stream mid-response, that extraWarn:line fails an otherwise passing test. On 2026-11-17/18 this happened on every cloud, several tests per run.Judgment calls:
context deadline exceededis theOperationBuffer.Drainbudget, which a slow service also hits; it is best effort too. An error the service returns, such as a validation error or an empty-message 5xx, is still compared. A blanket filter on these warnings would have hidden real CLI bugs like theoperations.resource_key must have a known resource typeregression. Thedms_faultanddmstests assert their injected warnings, which don't match (indented, orFault injected by test).libs/retry.IsTransientReadonly matches*url.Error, and these errors come from the SDK's body read (response body: ...). Close dead HTTP/2 connections in the bundle workspace client #7723 adds HTTP/2 health-check pings for dead connections and does not change this.[CLI] api get .../resourcesfailures in test scripts. The backend side is reported to the service owners.Tests
TestAccept/bundle/{dms,dms_fault,resources/secrets,config-remote-sync}pass.TestAccept/bundle/config-remote-sync/cli_defaults/DMS=truepasses. The commit message runs three affected tests on every cloud.Dashboard:
Warn: Failed to record deployment history: recording operation for resources.pipelines.[NAME]: response body: stream error: stream ID 51; INTERNAL_ERROR; received from peerWarn: Failed to complete deployment history version: response body: stream error: stream ID 63; INTERNAL_ERROR; received from peerWarn: Failed to record deployment history: recording operation for resources.postgres_roles.[NAME]: response body: stream error: stream ID 69; INTERNAL_ERROR; received from peerWarn: Failed to complete deployment history version: response body: stream error: stream ID 9429; INTERNAL_ERROR; received from peerWarn: Could not enable deployment history for this deploy: failed to create deployment: response body: stream error: stream ID 43; INTERNAL_ERROR; received from peerWarn: Failed to record deployment history: context deadline exceededWarn: Failed to record deployment history: recording operation for resources.catalogs.[NAME]: Patch "[DATABRICKS_URL]/api/2.0/bundle/deployments/[DEPLOYMENT_ID]/versions/<N>/operations/catalogs.catalog1": unexpected EOFThis pull request and its description were written by Isaac.