Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Cloud = false
EnvMatrix.DMS = ["true"]
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Warn: Could not enable deployment history for this deploy: failed to create deployment:
Warn: Could not enable deployment history for this deploy: failed to create deployment version: operations.resource_key must have a known resource type
Warn: Failed to complete deployment history version: Internal error
Error: cannot create resources.secrets.foo: response body: stream error: stream ID 73; INTERNAL_ERROR; received from peer
14 changes: 14 additions & 0 deletions acceptance/bundle/dms/suppress-transport-warnings/script
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Suppressed: best-effort history warnings caused by a dropped connection or the drain budget.
echo "Warn: Failed to record deployment history: recording operation for resources.pipelines.foo: response body: stream error: stream ID 51; INTERNAL_ERROR; received from peer"
echo "Warn: Failed to complete deployment history version: response body: stream error: stream ID 9429; INTERNAL_ERROR; received from peer"
echo "Warn: Could not enable deployment history for this deploy: failed to create deployment: response body: stream error: stream ID 43; INTERNAL_ERROR; received from peer"
echo "Warn: Could not record deployment history for this destroy: failed to create deployment version: unexpected EOF"
echo "Warn: Could not read deployment history: response body: stream error: stream ID 13; INTERNAL_ERROR; received from peer"
echo "Warn: Could not delete deployment history: response body: stream error: stream ID 7; INTERNAL_ERROR; received from peer"
echo "Warn: Failed to record deployment history: context deadline exceeded"

# Kept: errors the service returns, and transport errors outside deployment history.
echo "Warn: Could not enable deployment history for this deploy: failed to create deployment: "
echo "Warn: Could not enable deployment history for this deploy: failed to create deployment version: operations.resource_key must have a known resource type"
echo "Warn: Failed to complete deployment history version: Internal error"
echo "Error: cannot create resources.secrets.foo: response body: stream error: stream ID 73; INTERNAL_ERROR; received from peer"
3 changes: 3 additions & 0 deletions acceptance/bundle/dms/suppress-transport-warnings/test.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Only echoes lines: no workspace, no requests.
Cloud = false
RecordRequests = false
9 changes: 9 additions & 0 deletions acceptance/bundle/test.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,15 @@ Ignore = ["databricks.yml"]
# The lowest Python version we support. Alternative to "uv run --python 3.10"
Env.UV_PYTHON = "3.10"

# Recording history is best effort: with recording on, the CLI only warns when a call to the
# service fails. The plain run makes no such calls, and the goldens are shared, so such a warning
# would fail the DMS=true run. Suppressed (moved to the test log) only when the cause is a
# dropped connection (HTTP/2 stream reset, unexpected EOF) or the history drain budget running
# out ("context deadline exceeded" from OperationBuffer.Drain, which a slow service also hits).
# An error the service returns is still compared, so a request it rejects still fails the test.
# Pinned by bundle/dms/suppress-transport-warnings.
SuppressLines.warn_dms_transport = '^Warn: (Failed to (record|complete) deployment history|Could not (enable|record|read|delete) deployment history)\b.*(stream error: stream ID \S+; INTERNAL_ERROR; received from peer|unexpected EOF|context deadline exceeded)$'

# The link a recorded deploy prints, dropped so a test asserts the same output whether or
# not recording is on. The URL itself is covered by workspaceurls.TestDeploymentURL, and
# the calls behind it by the bundle/dms tests.
Expand Down
Loading