Repository navigation
Conversation
Bundle tests for removing a field from each postgres resource, plus a raw-API factcheck showing how each Update API clears a field under a field mask and under update_mask=spec. The testserver now matches what the real API did on 2026-11-19 for these requests. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 9 changed tests (limit=20, 0 not selected) 17 tests: regression=0 unreleased=0 coverage=17 failing=0
|
Co-authored-by: Isaac <no-reply@databricks.com>
andrewnester
approved these changes
Nov 19, 2026
Collaborator
✅ Integration test reportCommit: 486c171
Top 50 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
New bundle tests that remove a field from each postgres resource and record the deploy, the PATCH, the read-back and the following plan: project
custom_tags(shrink, then remove),default_endpoint_settings.pg_settingskey,enable_pg_native_login; endpointsettings.pg_settingskey,disabled; branchis_protected; roleattributes.createdb,membership_roles.New raw-API factcheck
postgres_projects/factcheck/clear_field: for each resource, clears a field by masking it with the field omitted, by maskingspecwith it omitted, and by maskingspecwith the zero value sent.The testserver is updated to match what the real API returned for these requests: a masked repeated field the body omits is cleared, a masked map the body omits is kept,
update_mask=speckeeps an omittedis_protected/disabled/ role attribute, role updates reject a masked scalar with no value, and project/endpoint status reflectcustom_tags,pg_settingsandenable_pg_native_login.Why
To see what changes if postgres resources switch to
update_mask=spec(#7806), we need a baseline of what removals do today on a real workspace. Today: removing a list entry, a whole list or a map key works; removing a bool fails with 400 (is in update_mask but not provided in request), recorded as Badness.The factcheck is meant for the Lakebase team: an omitted scalar cannot be cleared under either mask, and under
specan omitted repeated field is kept for projectcustom_tagsbut cleared for rolemembership_roles.Tests
All new tests were generated against an AWS workspace and pass locally against the testserver.
This pull request and its description were written by Isaac.