Repository navigation
Conversation
…ts, roles and databases Removing a scalar no longer fails with 400 but is silently ignored, and removing all project custom_tags, which worked with the field mask, is now silently ignored too. Badness is updated from runs against a real workspace on 2026-11-19. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 20 changed tests (limit=20, 5 not selected) 39 tests: regression=38 unreleased=0 coverage=1 failing=0
TestAccept/bundle/resources/postgres_branches/remove_is_protected/DMS=: branch ✅ | main (ccaea75) ❌ | latest (v1.27.0) ❌main (ccaea75): latest (v1.27.0): TestAccept/bundle/resources/postgres_branches/remove_is_protected/DMS=true: branch ✅ | main (ccaea75) ❌ | latest (v1.27.0) ❌main (ccaea75): latest (v1.27.0): TestAccept/bundle/resources/postgres_branches/update_expire_time/DMS=: branch ✅ | main (ccaea75) ❌ | latest (v1.27.0) ❌main (ccaea75): latest (v1.27.0): same output as main (ccaea75) TestAccept/bundle/resources/postgres_branches/update_expire_time/DMS=true: branch ✅ | main (ccaea75) ❌ | latest (v1.27.0) ❌main (ccaea75): latest (v1.27.0): TestAccept/bundle/resources/postgres_branches/update_protected/DMS=: branch ✅ | main (ccaea75) ❌ | latest (v1.27.0) ❌main (ccaea75): latest (v1.27.0): same output as main (ccaea75) TestAccept/bundle/resources/postgres_branches/update_protected/DMS=true: branch ✅ | main (ccaea75) ❌ | latest (v1.27.0) ❌main (ccaea75): latest (v1.27.0): same output as main (ccaea75) TestAccept/bundle/resources/postgres_branches/update_ttl/DMS=: branch ✅ | main (ccaea75) ❌ | latest (v1.27.0) ❌main (ccaea75): latest (v1.27.0): same output as main (ccaea75) TestAccept/bundle/resources/postgres_branches/update_ttl/DMS=true: branch ✅ | main (ccaea75) ❌ | latest (v1.27.0) ❌main (ccaea75): latest (v1.27.0): same output as main (ccaea75) 30 more failure details omitted, see the full report in the run. |
Collaborator
✅ Integration test reportCommit: c4e1924
Top 50 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Stacked on #7805. Postgres projects, branches, endpoints, roles and databases send
update_mask=specwith the full desired spec, instead of a mask built from the plan's changed paths. Badness is updated from runs against an AWS workspace on 2026-11-19. The testserver now matches cloud for this mask: GET echoes back the spec as sent, while status keeps omitted fields.Why
To check whether
specwould fix the field-mask failures without breaking anything. It doesn't, so this is a no-go:custom_tagsworked withupdate_mask=spec.custom_tags. Withspecthe API keeps the tags, and the SDK can't send an empty list instead (postgres_projects/remove_custom_tags).default_endpoint_settingsblock no longer fails with 400.history_retention_duration,suspend_timeout_duration,enable_pg_native_login,disabled,is_protectedor a role attribute failed with 400 every deploy. Now the deploy succeeds, the old value stays, and the plan shows no drift, because GET echoes back the spec as sent.custom_tags, and clearingmembership_roleswork under both masks.Tests
All changed acceptance tests were rerun against the real workspace with this change, and pass locally against the testserver.
This pull request and its description were written by Isaac.