Repository navigation
Conversation
|
Commit: Regression test reportSelected 2 changed tests (limit=20, 0 not selected) 4 tests: regression=0 unreleased=0 coverage=4 failing=0
|
✅ Integration test reportCommit: 58980ce
Top 48 slowest tests (at least 2 minutes):
|
Sankalp-Mittal
left a comment
There was a problem hiding this comment.
[AI Generated] Review by review-factory (Claude Fable 5.2 + Claude Opus 5.5, cross-verified). Only points the reviewers agreed on are posted.
No blocking or major issues found.
| from_flag: ${var.from_flag} | ||
| from_env: ${var.from_env} | ||
| leading_zero_int: ${var.leading_zero_int} | ||
| interpolated: id-${var.leading_zero} |
There was a problem hiding this comment.
[AI Generated] id-${var.leading_zero} renders as id-1.2345678901234e+13, while the pure reference gives 12345678901234. If that's a bug, can a test.toml Badness line record it, like target_timestamp_shorthand does?
| @@ -0,0 +1,100 @@ | |||
| # Unquoted scalars that YAML resolves to a number, bool or timestamp, used in | |||
| # string-typed fields. Each value is written twice: unquoted and quoted ("q_"). | |||
There was a problem hiding this comment.
[AI Generated] nit: Only tags and base_parameters have q_ pairs; name, parameters, git_commit, the ids and the pipeline fields are written once, unquoted. Can the header say that instead of "each value is written twice"?
| name: numeric-defaults | ||
|
|
||
| variables: | ||
| # YAML resolves this to a float: with a leading "0" it is not a valid octal int (has 8, 9). |
There was a problem hiding this comment.
[AI Generated] nit: The float comes from yaml.v3, not YAML: the 1.2 core schema reads 0012345678901234 as an int and PyYAML keeps it a string. Can this say "yaml.v3 resolves"?
Cover fields that hold ids, versions and tags, both as literals and via
${var.x}. Outputs record the current lossy conversion (leading zeros,
trailing zeros, exponents, hex/octal, interpolated floats).
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
3178a31 to
58980ce
Compare
Sankalp-Mittal
left a comment
There was a problem hiding this comment.
[AI Generated] Review by review-factory (Claude Fable 5.2 + Claude Opus 5.5, cross-verified). Only points the reviewers agreed on are posted.
No issues found.
Changes
New acceptance tests
bundle/validate/yaml_numeric_stringsandbundle/validate/variables/numeric_defaults. Outputs record current behavior, no code changes.Why
Follow-up to #7793. An unquoted value that YAML resolves to a number is converted back to a string in string fields, and the source text is lost:
0042→42,1.10→1.1,1e3→1000,0x1F→31,True→true, git_commit1234e56→ 60 digits, ids with a leading zero lose it. Variable defaults keep the number type, so${var.x}loses the text the same way. On top of that,id-${var.x}with default0012345678901234givesid-1.2345678901234e+13: yaml.v3 resolves leading-zero values containing 8/9 as floats, and interpolation formats them withfmt.Sprint. Values from--varandBUNDLE_VAR_*are strings and are kept as-is.Tests
Only new tests.
This pull request and its description were written by Isaac.