Repository navigation
Conversation
Contributor
|
Commit: Regression test reportSelected 13 changed tests (limit=20, 0 not selected) 17 tests: regression=17 unreleased=0 coverage=0 failing=0
TestAccept/bundle/deployment/bind/dashboard/recreation/DMS=/READPLAN=: branch ✅ | main (ef8fc0b) ❌ | latest (v1.27.0) ❌main (ef8fc0b): latest (v1.27.0): same output as main (ef8fc0b) TestAccept/bundle/deployment/bind/dashboard/recreation/DMS=/READPLAN=1: branch ✅ | main (ef8fc0b) ❌ | latest (v1.27.0) ❌main (ef8fc0b): latest (v1.27.0): same output as main (ef8fc0b) TestAccept/bundle/deployment/bind/dashboard/recreation/DMS=true/READPLAN=: branch ✅ | main (ef8fc0b) ❌ | latest (v1.27.0) ❌main (ef8fc0b): latest (v1.27.0): same output as main (ef8fc0b) TestAccept/bundle/deployment/bind/dashboard/recreation/DMS=true/READPLAN=1: branch ✅ | main (ef8fc0b) ❌ | latest (v1.27.0) ❌main (ef8fc0b): latest (v1.27.0): same output as main (ef8fc0b) TestAccept/bundle/deployment/bind/job/undeployed-dependency/DMS=: branch ✅ | main (ef8fc0b) ❌ | latest (v1.27.0) ❌main (ef8fc0b): latest (v1.27.0): same output as main (ef8fc0b) TestAccept/bundle/deployment/bind/job/undeployed-dependency/DMS=true: branch ✅ | main (ef8fc0b) ❌ | latest (v1.27.0) ❌main (ef8fc0b): latest (v1.27.0): same output as main (ef8fc0b) TestAccept/bundle/dms_fault/complete_version/DMS=true: branch ✅ | main (ef8fc0b) ❌ | latest (v1.27.0) ❌main (ef8fc0b): latest (v1.27.0): TestAccept/bundle/dms_fault/delete_deployment/DMS=true: branch ✅ | main (ef8fc0b) ❌ | latest (v1.27.0) ❌main (ef8fc0b): latest (v1.27.0): TestAccept/bundle/dms_fault/get_operation/DMS=true: branch ✅ | main (ef8fc0b) ❌ | latest (v1.27.0) ❌main (ef8fc0b): latest (v1.27.0): 8 more failure details omitted, see the full report in the run. |
Collaborator
✅ Integration test reportCommit: 576c34c
Top 3 slowest tests (at least 2 minutes):
|
Bind now builds a bind plan where the bound resource is a state-only update at the new ID, applies it with the regular Apply to a temp copy of the state to compute the plan shown to the user, and on confirmation applies the same bind plan to the real state instead of renaming the temp file over it. Co-authored-by: Isaac <no-reply@databricks.com>
The bound resource's state-only update is now decided in planNode, next to the other state-only updates, instead of being assembled in bind.go from a copy of the plan entry. The bind plan reuses FilterToSelected to keep only the bound resource and its dependencies. Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/bind-via-plan-apply
branch
from
November 20, 2026 13:01
178e6f7 to
576c34c
Compare
denik
changed the base branch from
main
to
denik/bind-test-undeployed-dependency
November 20, 2026 13:01
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
bundle deployment bindnow reuses the plan and apply code. It plans with the resource recorded at the new ID and turns its entry into a state-only update (the bind plan). The bind plan is applied to a temp copy of the state to compute the plan shown to the user; after confirmation the same bind plan is applied to the real state, replacing the rename of the temp state file.Why
Removes the hand-written state writes in bind: recording the resource now goes through the same Apply path as deploy (WAL, deployment history shadow).
Tests
Stacked on #7846, which adds bind/job/undeployed-dependency. Bind now writes the state once instead of twice, so the serial after bind is one lower in that test and in bind/dashboard/recreation, and the version links in dms_fault/* move down accordingly.
This pull request and its description were written by Isaac.