Skip to content

acc: add bind test for a resource that references an undeployed one - #7846

Open
denik wants to merge 1 commit into
mainfrom
denik/bind-test-undeployed-dependency
Open

denik wants to merge 1 commit into
mainfrom
denik/bind-test-undeployed-dependency

Conversation

@denik

@denik denik commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Binds a job that references both a deployed job and a job that is not deployed yet. No existing bind test has a bound resource that references an undeployed one; split out of #7813 so its effect on this test's output shows as a diff.

This pull request and its description were written by Isaac.

Binds a job that references both a deployed job and a job that is not
deployed yet, and checks the state bind leaves and the deploy after it.

Co-authored-by: Isaac <no-reply@databricks.com>
@denik
denik requested review from a team as code owners November 20, 2026 13:01
@github-actions github-actions Bot added DABs DABs related issues test-only-fix PRs that update failing of flaky tests without changing CLI code. labels Nov 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Commit: f3281fb1b | Workflow run

Regression test report

Selected 1 changed tests (limit=20, 0 not selected)

2 tests: regression=0 unreleased=0 coverage=2 failing=0
test branch main (ef8fc0b) latest (v1.27.0)
TestAccept/bundle/deployment/bind/job/undeployed-dependency/DMS= ✅ ✅ ✅
TestAccept/bundle/deployment/bind/job/undeployed-dependency/DMS=true ✅ ✅ ✅

@review-oss-bot review-oss-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review at f3281fb. Each finding was verified against the code.

Not ready yet: 1 blocking issue(s), tagged [blocking].

This PR adds an acceptance test for binding a job that references an undeployed resource. The test scenario is well structured and the golden output clearly shows the before-and-after of bind and deploy. However, test.toml is missing an Ignore entry for the .databricks directory created by bundle deploy and bundle deployment bind, which will cause the harness to report unexpected files and fail the test.

@@ -0,0 +1 @@
Cloud = false

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[blocking] The script creates .databricks/bundle/default/ via bundle deploy and bundle deployment bind, but no ancestor test.toml ignores .databricks (the parent chain only has Ignore = ["databricks.yml"] and the framework auto-adds .cache). After the script finishes the harness lists the temp dir (acceptance_test.go:1157) and flags every file not in inputs, outputs, or the compiled ignore set as unexpected (t.Error at line 1189). Add Ignore = [".databricks"] here.

@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: f3281fb

Run: 44740737482

Env 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux-2core-8gb 1 272 20 3:48
💚​ aws-windows-latest-4core-16gb 1 274 18 4:01
💚​ azure linux-2core-8gb 1 271 20 3:26
💚​ azure-windows-latest-4core-16gb 1 273 18 4:10
💚​ gcp linux-2core-8gb 1 272 20 3:41
💚​ gcp-windows-latest-4core-16gb 1 274 18 4:10
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
Top 3 slowest tests (at least 2 minutes):
duration env testname
4:09 azure-windows-latest-4core-16gb TestAccept
4:08 gcp-windows-latest-4core-16gb TestAccept
3:59 aws-windows-latest-4core-16gb TestAccept

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DABs DABs related issues test-only-fix PRs that update failing of flaky tests without changing CLI code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants