Repository navigation
Conversation
Binds a job that references both a deployed job and a job that is not deployed yet, and checks the state bind leaves and the deploy after it. Co-authored-by: Isaac <no-reply@databricks.com>
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 2 tests: regression=0 unreleased=0 coverage=2 failing=0
|
There was a problem hiding this comment.
Automated review at f3281fb. Each finding was verified against the code.
Not ready yet: 1 blocking issue(s), tagged [blocking].
This PR adds an acceptance test for binding a job that references an undeployed resource. The test scenario is well structured and the golden output clearly shows the before-and-after of bind and deploy. However, test.toml is missing an Ignore entry for the .databricks directory created by bundle deploy and bundle deployment bind, which will cause the harness to report unexpected files and fail the test.
| @@ -0,0 +1 @@ | |||
| Cloud = false | |||
There was a problem hiding this comment.
[blocking] The script creates .databricks/bundle/default/ via bundle deploy and bundle deployment bind, but no ancestor test.toml ignores .databricks (the parent chain only has Ignore = ["databricks.yml"] and the framework auto-adds .cache). After the script finishes the harness lists the temp dir (acceptance_test.go:1157) and flags every file not in inputs, outputs, or the compiled ignore set as unexpected (t.Error at line 1189). Add Ignore = [".databricks"] here.
✅ Integration test reportCommit: f3281fb
Top 3 slowest tests (at least 2 minutes):
|
Binds a job that references both a deployed job and a job that is not deployed yet. No existing bind test has a bound resource that references an undeployed one; split out of #7813 so its effect on this test's output shows as a diff.
This pull request and its description were written by Isaac.