Repository navigation
feat(kernel): expose HTTP/2 opt-out #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
14f842d
d7c5fc6
11785b3
3d5c8ca
8676c56
2c1163a
98ec0d6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ | |
|
|
||
| - Avoid intermediate decimal strings when materializing Arrow DECIMAL values with safe unscaled integers, on both backends. | ||
| - Reduce Arrow row materialization overhead on both backends by reading vectors directly and resolving scalar conversions once per batch. Object and array row values are unchanged. | ||
| - Kernel HTTPS traffic negotiates HTTP/2 with HTTP/1.1 fallback. Set `enableHttp2: false` to force HTTP/1.1. Configured proxies also force HTTP/1.1. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Medium — Every platform binding is still pinned to 🔀 Found by Claude Opus 5.5 · the judge couldn't confirm it
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Duplicate of the release prerequisite at There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This PR will merge only together with the KERNEL_REV and platform-pin bump, so the Unreleased entry will be accurate when it lands. A temporary caveat would be removed in that same push. The matching release of kernel #483 remains a merge prerequisite. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Medium — The changelog says HTTP/2 is negotiated, but package.json still pins every kernel binding to 1.4.0. If 1.4.0 predates the kernel change, the option is silently ignored. Bump the pins in this PR, or state the required kernel package version and reference the kernel change. 🔀 Found by Claude Opus 5.5 · confirmed by the judge
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Duplicate of the release prerequisite at There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Still open at b655703: the kernel pins are unchanged, and the CHANGELOG.md:6 entry doesn't name the required kernel release or link databricks-sql-kernel#483.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This PR will merge only together with the KERNEL_REV and platform-pin bump, so the Unreleased entry will be accurate when it lands. A temporary caveat would be removed in that same push. The matching release of kernel #483 remains a merge prerequisite. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Still open at 0d563d5: package.json:95-102 still pins kernel 1.4.0. Keep this open as a merge blocker until the bump lands. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔵 Low — The changelog entry presents HTTP/2 negotiation as shipped, but it depends on a native package release that isn't pinned yet, and the entry doesn't mention that. State the required kernel release or package bump, or land the entry together with the pin update. 🔀 Found by Claude Opus 5.5 · confirmed by the judge
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Duplicate of the release prerequisite at There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Still open at b655703: CHANGELOG.md:6 still doesn't name the required kernel release (databricks-sql-kernel#483) or the package bump.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This PR will merge only together with the KERNEL_REV and platform-pin bump, so the Unreleased entry will be accurate when it lands. A temporary caveat would be removed in that same push. The matching release of kernel #483 remains a merge prerequisite. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Still open at 0d563d5: KERNEL_REV and platform pins aren't bumped yet, so CHANGELOG.md:6 still describes support that isn't shipped. This resolves once the pin lands. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔵 Low — The changelog entry presents HTTP/2 control as shipped, but the pinned 1.4.0 native packages don't support the field. State the required kernel release and native package bump, or land the pin bump with this entry. 🔀 Found by Claude Opus 5.5 · confirmed by the judge |
||
| - The Thrift token federation exchange (`enableTokenFederation`) now goes through the connection's agent, so `proxy`, `checkServerCertificate`, `customCaCert` and `clientCert`/`clientKey` apply to it. Previously it connected directly with Node's default agent, so behind a required proxy the exchange failed and the driver fell back to the original token. (#611) | ||
| - Kernel backend: a failed status poll while waiting for a statement (a `runAsync: true` statement, or a default execution that outlives the server's inline wait) and a failed result fetch in `hasMoreRows()` now throw the mapped driver error, such as `HiveDriverError: HTTP 500: Internal Server Error` once retries on HTTP 5xx run out, instead of a raw `Error` whose message is the internal `__databricks_error__:{...}` envelope. As in `fetchChunk()`, a failed fetch in `hasMoreRows()` also closes the statement. (#608) | ||
| - Honor `cloudFetchConcurrentDownloads` when opening kernel sessions, with a default window of 16 and explicit chunk-setting overrides. Values other than positive safe integers raise `HiveDriverError` at session open. | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -238,6 +238,7 @@ export interface KernelTlsOptions { | |
| * the kernel folds last-wins). | ||
| */ | ||
| export interface KernelHttpOptions { | ||
| enableHttp2?: boolean; | ||
| customHeaders?: Array<{ name: string; value: string }>; | ||
| socketTimeoutMs?: number; | ||
| } | ||
|
|
@@ -523,6 +524,12 @@ export function buildKernelHttpOptions(options: ConnectionOptions): KernelHttpOp | |
| headers.push({ name: 'User-Agent', value: buildUserAgentString(userAgentEntry) }); | ||
|
|
||
| const http: KernelHttpOptions = { customHeaders: headers }; | ||
| if (options.enableHttp2 !== undefined) { | ||
| if (typeof options.enableHttp2 !== 'boolean') { | ||
| throw new HiveDriverError('kernel backend: `enableHttp2` must be a boolean.'); | ||
| } | ||
| http.enableHttp2 = options.enableHttp2; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟠 High — 🔀 Found by Claude Opus 5.5 · confirmed by the judge
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Duplicate of the release prerequisite at There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟠 High — 🔀 Found by GPT-6.1 Sol · confirmed by the judge
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Duplicate of the release prerequisite at There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Still open at b655703: the platform package pins and lockfile still need bumping to a kernel release that supports enableHttp2 before merge. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟠 High — The option is forwarded to native packages still pinned at 1.4.0 in package.json. The diff doesn't show those binaries supporting it, so the opt-out would be silently ignored for published installs. Bump KERNEL_REV and all eight platform pins, regenerate the binding, and verify the option, or gate the merge on the kernel release. 🔀 Found by both reviewers · confirmed by the judge
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Duplicate of the release prerequisite at #626 (comment). This PR is blocked on the kernel #483 release; KERNEL_REV, all eight platform pins and the lockfile must be updated, and native/kernel/index.* regenerated with npm run build:native, before merge. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟠 High — The driver forwards 🔀 Found by both reviewers · confirmed by the judge
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Duplicate of the release prerequisite at #626 (comment). This PR is blocked on the kernel #483 release; KERNEL_REV, all eight platform pins and the lockfile must be updated, and native/kernel/index.* regenerated with npm run build:native, before merge. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Still open at 0d563d5: the kernel pins, KERNEL_REV, lockfile and regenerated bindings must ship with this change before merge. |
||
| } | ||
| // Per-connection socket read timeout (ms). The public `socketTimeout` | ||
| // ConnectionOption maps onto the kernel napi `socketTimeoutMs` | ||
| // (kernel `HttpConfig::request_timeout` / reqwest `Client::timeout`). | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Medium — The changelog claims HTTP/2 negotiation and
enableHttp2: falsework, but the platform packages are pinned to 1.4.0, which has no such field in this diff. Add the published-package caveat and the kernel change reference, or land the pin bump with the entry.🔀 Found by Claude Opus 5.5 · confirmed by the judge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate of the release prerequisite at
native/kernel/index.d.ts:781. Blocked on a kernel release that includes https://github.com/databricks/databricks-sql-kernel/pull/483; the dependency and generated-file updates listed in that thread remain required before merge.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still open at b655703: CHANGELOG.md:6 still has no published-package caveat or kernel PR reference, and the pins are still not bumped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR will merge only together with the KERNEL_REV and platform-pin bump, so the Unreleased entry will be accurate when it lands. A temporary caveat would be removed in that same push. The matching release of kernel #483 remains a merge prerequisite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still open at 0d563d5: platform pins remain 1.4.0 (package.json:95-102), and CHANGELOG.md:6 lacks the caveat or kernel #483 reference.