Repository navigation
feat(kernel): expose HTTP/2 opt-out - #626
aakash-saravanan-db wants to merge 7 commits into
Conversation
There was a problem hiding this comment.
🔀 Cross-reviewed: two independent reviews (Claude Opus 5.5 · GPT-6.1 Sol), checked by a judge model (Claude Sonnet 5.5).
Verdict: 1 Medium · 1 Low
One medium and one low concern. The validation and forwarding are correct and tested, but the native declaration was edited by hand while the binding pins stay at 1.4.0, so the option probably does nothing in published builds.
| */ | ||
| enableGeoSpatialSupport?: boolean | ||
| /** Negotiate HTTP/2 over HTTPS by default. False or a configured proxy forces HTTP/1.1. */ | ||
| enableHttp2?: boolean |
There was a problem hiding this comment.
🟡 Medium — The enableHttp2 field was hand-added to the NAPI-generated native/kernel/index.d.ts, but every platform pin in package.json and package-lock.json is still 1.4.0. I couldn't confirm that 1.4.0 supports the field. If it doesn't, NAPI will silently drop it and enableHttp2: false will do nothing. Regenerate the typings from a binding build that has the field, and bump all platform pins together, or hold the PR until that binding is published.
🔀 Found by Claude Opus 5.5 · confirmed by the judge
There was a problem hiding this comment.
The added enableHttp2 declaration and its documentation match the corresponding kernel binding declaration, and actual matching-native transport checks cover omitted, true and false values. This PR is held for that binding: matching native package integration is an explicit merge/release prerequisite in the description. No release version has been assigned in this change.
There was a problem hiding this comment.
Still open at 4fb6fa0: every platform pin is still 1.4.0 (package.json:95-102); keep this open until a binding with enableHttp2 ships and all pins are bumped.
There was a problem hiding this comment.
This is a merge prerequisite. The pinned kernel source dac32e2b has no HTTP/2 option, and the currently published platform version is 1.4.0. After kernel #483 is merged/released, this PR must update KERNEL_REV, all eight platform pins and the lockfile, regenerate index.js/index.d.ts through npm run build:native, and pass the regeneration check. The PR remains blocked until those changes land.
|
|
||
| ## Unreleased | ||
|
|
||
| - Add kernel-only `enableHttp2`: HTTPS negotiates HTTP/2 with HTTP/1.1 fallback; set `enableHttp2: false` to force HTTP/1.1 for all kernel-owned HTTPS requests. Configured proxies, including environment proxy variables, force HTTP/1.1. |
There was a problem hiding this comment.
🔵 Low — The changelog entry presents enableHttp2 as available. It doesn't name the minimum published kernel binding version, a required follow-up package bump, or the kernel change that adds the field. Add the required kernel version, or a note about the pending bump, and link the kernel PR.
🔀 Found by Claude Opus 5.5 · confirmed by the judge
There was a problem hiding this comment.
The entry is under Unreleased. Matching binding integration and kernel #483 are explicit dependencies in the PR description, and this PR remains blocked until those artifacts are available. A minimum published version cannot be named before that coordinated release is assigned.
There was a problem hiding this comment.
Duplicate of the release prerequisite at native/kernel/index.d.ts:781. Blocked on a kernel release that includes https://github.com/databricks/databricks-sql-kernel/pull/483; the dependency and generated-file updates listed in that thread remain required before merge.
There was a problem hiding this comment.
This PR will merge only together with the KERNEL_REV and platform-pin bump, so the Unreleased entry will be accurate when it lands. A temporary caveat would be removed in that same push. The matching release of kernel #483 remains a merge prerequisite.
There was a problem hiding this comment.
Still open at 0d563d5: CHANGELOG.md:6 still describes a feature that isn't shipped. This resolves once the KERNEL_REV and platform-pin bump lands in this PR.
There was a problem hiding this comment.
🔀 Cross-reviewed: two independent reviews (Claude Opus 5.5 · GPT-6.1 Sol), checked by a judge model (Claude Sonnet 5.5).
Verdict: 1 High · 1 Medium · 1 Low
Needs changes: 1 high concern. The forwarding code and its validation look right, but the option needs a published kernel binding that this PR doesn't pin, so the documented opt-out does nothing on shipped installs.
|
|
||
| ## Unreleased | ||
|
|
||
| - Kernel HTTPS traffic negotiates HTTP/2 with HTTP/1.1 fallback. Set `enableHttp2: false` to force HTTP/1.1. Configured proxies also force HTTP/1.1. |
There was a problem hiding this comment.
🟡 Medium — The changelog claims HTTP/2 negotiation and enableHttp2: false work, but the platform packages are pinned to 1.4.0, which has no such field in this diff. Add the published-package caveat and the kernel change reference, or land the pin bump with the entry.
🔀 Found by Claude Opus 5.5 · confirmed by the judge
There was a problem hiding this comment.
Duplicate of the release prerequisite at native/kernel/index.d.ts:781. Blocked on a kernel release that includes https://github.com/databricks/databricks-sql-kernel/pull/483; the dependency and generated-file updates listed in that thread remain required before merge.
There was a problem hiding this comment.
Still open at b655703: CHANGELOG.md:6 still has no published-package caveat or kernel PR reference, and the pins are still not bumped.
There was a problem hiding this comment.
This PR will merge only together with the KERNEL_REV and platform-pin bump, so the Unreleased entry will be accurate when it lands. A temporary caveat would be removed in that same push. The matching release of kernel #483 remains a merge prerequisite.
| if (typeof options.enableHttp2 !== 'boolean') { | ||
| throw new HiveDriverError('kernel backend: `enableHttp2` must be a boolean.'); | ||
| } | ||
| http.enableHttp2 = options.enableHttp2; |
There was a problem hiding this comment.
🟠 High — enableHttp2 is forwarded to the native binding, but every optionalDependency is still pinned to 1.4.0 and this diff doesn't bump them. An older binding drops the unknown field silently, so enableHttp2: false does nothing. Bump all platform pins to a binding that has the field, or add a capability check.
🔀 Found by Claude Opus 5.5 · confirmed by the judge
There was a problem hiding this comment.
Duplicate of the release prerequisite at native/kernel/index.d.ts:781. Blocked on a kernel release that includes https://github.com/databricks/databricks-sql-kernel/pull/483; the dependency and generated-file updates listed in that thread remain required before merge.
| * to SEA. | ||
| */ | ||
| enableGeoSpatialSupport?: boolean | ||
| /** Negotiate HTTP/2 over HTTPS by default. False or a configured proxy forces HTTP/1.1. */ |
There was a problem hiding this comment.
🔵 Low — The generated native/kernel/index.d.ts was hand-edited, and the diff doesn't touch KERNEL_REV or the pins. CI's check that the committed binding matches KERNEL_REV would likely fail. Regenerate the file from a binding build that exposes enableHttp2, and bump the pin in the same change.
🔀 Found by Claude Opus 5.5 · confirmed by the judge
There was a problem hiding this comment.
Duplicate of the release prerequisite at native/kernel/index.d.ts:781. Blocked on a kernel release that includes https://github.com/databricks/databricks-sql-kernel/pull/483; the dependency and generated-file updates listed in that thread remain required before merge.
There was a problem hiding this comment.
Still open at b655703: index.d.ts is still hand-edited and has no KERNEL_REV or pin bump; this stays open until the kernel release lands.
There was a problem hiding this comment.
🔀 Cross-reviewed: two independent reviews (Claude Opus 5.5 · GPT-6.1 Sol), checked by a judge model (Claude Sonnet 5.5).
Verdict: 1 Medium · 1 Low
The forwarding and validation code is fine, with 1 medium concern and 1 low. The enableHttp2 option is declared and documented, but the pinned native binding (1.4.0) doesn't support it yet. Nit: the new CHANGELOG entry has a stray blank line after it, and the new CONNECTION_PARAMETERS row isn't padded to match the table's alignment.
| * to SEA. | ||
| */ | ||
| enableGeoSpatialSupport?: boolean | ||
| /** Negotiate HTTP/2 over HTTPS by default. False or a configured proxy forces HTTP/1.1. */ |
There was a problem hiding this comment.
🔵 Low — native/kernel/index.d.ts is napi-rs generated (marked linguist-generated, and CI diffs it against KERNEL_REV), but enableHttp2 was added without a KERNEL_REV change or a regenerated binding. Regenerate it from the pinned kernel build instead of hand-editing.
🔀 Found by Claude Opus 5.5 · confirmed by the judge
There was a problem hiding this comment.
Duplicate of the release prerequisite at native/kernel/index.d.ts:781. Blocked on a kernel release that includes https://github.com/databricks/databricks-sql-kernel/pull/483; the dependency and generated-file updates listed in that thread remain required before merge.
There was a problem hiding this comment.
Still open at b655703: enableHttp2 is hand-added at native/kernel/index.d.ts:780-781, with no KERNEL_REV bump or regenerated binding yet.
|
|
||
| ## Unreleased | ||
|
|
||
| - Kernel HTTPS traffic negotiates HTTP/2 with HTTP/1.1 fallback. Set `enableHttp2: false` to force HTTP/1.1. Configured proxies also force HTTP/1.1. |
There was a problem hiding this comment.
🟡 Medium — Every platform binding is still pinned to 1.4.0, which predates kernel #483. That means enableHttp2: false gets accepted and forwarded but probably has no effect in the shipped package, yet this entry says it works with no conditions. Either bump all the platform pins to a binding that has enableHttp2 in this PR, or say in the entry that it needs that release, reference kernel #483, and track the pin bump as follow-up.
🔀 Found by Claude Opus 5.5 · the judge couldn't confirm it
There was a problem hiding this comment.
Duplicate of the release prerequisite at native/kernel/index.d.ts:781. Blocked on a kernel release that includes https://github.com/databricks/databricks-sql-kernel/pull/483; the dependency and generated-file updates listed in that thread remain required before merge.
There was a problem hiding this comment.
This PR will merge only together with the KERNEL_REV and platform-pin bump, so the Unreleased entry will be accurate when it lands. A temporary caveat would be removed in that same push. The matching release of kernel #483 remains a merge prerequisite.
2b06bbd to
b3dcc28
Compare
There was a problem hiding this comment.
🔀 Cross-reviewed: two independent reviews (Claude Opus 5.5 · GPT-6.1 Sol), checked by a judge model (Claude Sonnet 5.5).
Verdict: 1 Medium · 1 Low
Looks correct: 1 medium and 1 low concern. Forwarding, validation and unit tests are fine, but the native pins are still 1.4.0, so enableHttp2 has no effect in the published package yet. Nit: the new CONNECTION_PARAMETERS.md row is wider than the table's padded column width; reformat it.
| * to SEA. | ||
| */ | ||
| enableGeoSpatialSupport?: boolean | ||
| /** Negotiate HTTP/2 over HTTPS by default. False or a configured proxy forces HTTP/1.1. */ |
There was a problem hiding this comment.
🔵 Low — enableHttp2 was added to native/kernel/index.d.ts while all platform packages are still pinned to 1.4.0, so the types may promise a field the shipped binary ignores. Regenerate the declarations from the pinned kernel build, or hold the change until the pin bump lands.
🔀 Found by Claude Opus 5.5 · confirmed by the judge
There was a problem hiding this comment.
Duplicate of the release prerequisite at native/kernel/index.d.ts:781. Blocked on a kernel release that includes https://github.com/databricks/databricks-sql-kernel/pull/483; the dependency and generated-file updates listed in that thread remain required before merge.
There was a problem hiding this comment.
Still open at b655703: native/kernel/index.d.ts:781 still declares enableHttp2, but the 1.4.0 binary and platform pins don't support it yet.
|
|
||
| ## Unreleased | ||
|
|
||
| - Kernel HTTPS traffic negotiates HTTP/2 with HTTP/1.1 fallback. Set `enableHttp2: false` to force HTTP/1.1. Configured proxies also force HTTP/1.1. |
There was a problem hiding this comment.
🟡 Medium — The changelog says HTTP/2 is negotiated, but package.json still pins every kernel binding to 1.4.0. If 1.4.0 predates the kernel change, the option is silently ignored. Bump the pins in this PR, or state the required kernel package version and reference the kernel change.
🔀 Found by Claude Opus 5.5 · confirmed by the judge
There was a problem hiding this comment.
Duplicate of the release prerequisite at native/kernel/index.d.ts:781. Blocked on a kernel release that includes https://github.com/databricks/databricks-sql-kernel/pull/483; the dependency and generated-file updates listed in that thread remain required before merge.
There was a problem hiding this comment.
Still open at b655703: the kernel pins are unchanged, and the CHANGELOG.md:6 entry doesn't name the required kernel release or link databricks-sql-kernel#483.
There was a problem hiding this comment.
This PR will merge only together with the KERNEL_REV and platform-pin bump, so the Unreleased entry will be accurate when it lands. A temporary caveat would be removed in that same push. The matching release of kernel #483 remains a merge prerequisite.
There was a problem hiding this comment.
Still open at 0d563d5: package.json:95-102 still pins kernel 1.4.0. Keep this open as a merge blocker until the bump lands.
There was a problem hiding this comment.
🔀 Cross-reviewed: two independent reviews (Claude Opus 5.5 · GPT-6.1 Sol), checked by a judge model (Claude Sonnet 5.5).
Verdict: 1 High · 1 Medium · 1 Low
The TypeScript changes look right, with 1 medium and 1 low concern, both about the generated native boundary. Forwarding, boolean validation and the omitted default are correct and covered by tests. The PR is blocked on the kernel #483 release: the native pins and the regenerated binding must land before merge.
This overview is Claude Opus 5.5's initial take; GPT-6.1 Sol added findings it doesn't mention — see the findings below.
| if (typeof options.enableHttp2 !== 'boolean') { | ||
| throw new HiveDriverError('kernel backend: `enableHttp2` must be a boolean.'); | ||
| } | ||
| http.enableHttp2 = options.enableHttp2; |
There was a problem hiding this comment.
🟠 High — enableHttp2 is forwarded to the native binding, but package.json still pins all eight @databricks/databricks-sql-kernel-* packages at 1.4.0, which the PR says lack the field. The option is silently ignored for npm consumers. Bump the platform pins and lockfile to the release that supports it, or have the router check for that support, before advertising the option.
🔀 Found by GPT-6.1 Sol · confirmed by the judge
There was a problem hiding this comment.
Duplicate of the release prerequisite at native/kernel/index.d.ts:781. Blocked on a kernel release that includes https://github.com/databricks/databricks-sql-kernel/pull/483; the dependency and generated-file updates listed in that thread remain required before merge.
There was a problem hiding this comment.
Still open at b655703: the platform package pins and lockfile still need bumping to a kernel release that supports enableHttp2 before merge.
|
|
||
| ## Unreleased | ||
|
|
||
| - Kernel HTTPS traffic negotiates HTTP/2 with HTTP/1.1 fallback. Set `enableHttp2: false` to force HTTP/1.1. Configured proxies also force HTTP/1.1. |
There was a problem hiding this comment.
🔵 Low — The changelog entry presents HTTP/2 negotiation as shipped, but it depends on a native package release that isn't pinned yet, and the entry doesn't mention that. State the required kernel release or package bump, or land the entry together with the pin update.
🔀 Found by Claude Opus 5.5 · confirmed by the judge
There was a problem hiding this comment.
Duplicate of the release prerequisite at native/kernel/index.d.ts:781. Blocked on a kernel release that includes https://github.com/databricks/databricks-sql-kernel/pull/483; the dependency and generated-file updates listed in that thread remain required before merge.
There was a problem hiding this comment.
Still open at b655703: CHANGELOG.md:6 still doesn't name the required kernel release (databricks-sql-kernel#483) or the package bump.
There was a problem hiding this comment.
This PR will merge only together with the KERNEL_REV and platform-pin bump, so the Unreleased entry will be accurate when it lands. A temporary caveat would be removed in that same push. The matching release of kernel #483 remains a merge prerequisite.
There was a problem hiding this comment.
Still open at 0d563d5: KERNEL_REV and platform pins aren't bumped yet, so CHANGELOG.md:6 still describes support that isn't shipped. This resolves once the pin lands.
| * to SEA. | ||
| */ | ||
| enableGeoSpatialSupport?: boolean | ||
| /** Negotiate HTTP/2 over HTTPS by default. False or a configured proxy forces HTTP/1.1. */ |
There was a problem hiding this comment.
🟡 Medium — native/kernel/index.d.ts is generated, and this enableHttp2 declaration was written by hand. The shipped 1.4.0 binding does not provide the field, so the type claims support that the native layer doesn't have yet. Remove the edit and regenerate the file with npm run build:native from the pinned kernel #483 release in the same change as the KERNEL_REV and platform-pin bumps.
🔀 Found by Claude Opus 5.5 · the judge couldn't confirm it
There was a problem hiding this comment.
Duplicate of the release prerequisite at native/kernel/index.d.ts:781. Blocked on a kernel release that includes https://github.com/databricks/databricks-sql-kernel/pull/483; the dependency and generated-file updates listed in that thread remain required before merge.
d3ea62b to
b655703
Compare
There was a problem hiding this comment.
🔀 Cross-reviewed: two independent reviews (Claude Opus 5.5 · GPT-6.1 Sol), checked by a judge model (Claude Sonnet 5.5).
Verdict: 1 High · 1 Low
The forwarding logic and tests look correct; I found 1 medium and 1 low concern. As the PR description says, the native pins still need a bump before merge, so enableHttp2 has no effect against the current 1.4.0 binding.
| * to SEA. | ||
| */ | ||
| enableGeoSpatialSupport?: boolean | ||
| /** Negotiate HTTP/2 over HTTPS by default. False or a configured proxy forces HTTP/1.1. */ |
There was a problem hiding this comment.
🔵 Low — native/kernel/index.d.ts is a generated napi boundary and was edited by hand, while KERNEL_REV and index.js are untouched. The types can drift from the real ABI. Regenerate it with npm run build:native against the kernel revision that adds the option.
🔀 Found by Claude Opus 5.5 · confirmed by the judge
There was a problem hiding this comment.
Duplicate of the release prerequisite at #626 (comment). This PR is blocked on the kernel #483 release; KERNEL_REV, all eight platform pins and the lockfile must be updated, and native/kernel/index.* regenerated with npm run build:native, before merge.
There was a problem hiding this comment.
Still open at 0d563d5: index.d.ts is still hand-edited, and KERNEL_REV, the platform pins and index.js are unchanged. Keeping this open until the regeneration lands.
| if (typeof options.enableHttp2 !== 'boolean') { | ||
| throw new HiveDriverError('kernel backend: `enableHttp2` must be a boolean.'); | ||
| } | ||
| http.enableHttp2 = options.enableHttp2; |
There was a problem hiding this comment.
🟠 High — The option is forwarded to native packages still pinned at 1.4.0 in package.json. The diff doesn't show those binaries supporting it, so the opt-out would be silently ignored for published installs. Bump KERNEL_REV and all eight platform pins, regenerate the binding, and verify the option, or gate the merge on the kernel release.
🔀 Found by both reviewers · confirmed by the judge
There was a problem hiding this comment.
Duplicate of the release prerequisite at #626 (comment). This PR is blocked on the kernel #483 release; KERNEL_REV, all eight platform pins and the lockfile must be updated, and native/kernel/index.* regenerated with npm run build:native, before merge.
There was a problem hiding this comment.
🔀 Cross-reviewed: two independent reviews (Claude Opus 5.5 · GPT-6.1 Sol), checked by a judge model (Claude Sonnet 5.5).
Verdict: 1 High · 1 Low
Mostly fine, with 1 medium and 1 low concern. enableHttp2 is checked to be a boolean and passed through to the kernel unchanged, and the tests cover it. The remaining issue is that the hand-edited native declarations and the docs describe kernel support that the pinned 1.4.0 binding doesn't ship.
| if (typeof options.enableHttp2 !== 'boolean') { | ||
| throw new HiveDriverError('kernel backend: `enableHttp2` must be a boolean.'); | ||
| } | ||
| http.enableHttp2 = options.enableHttp2; |
There was a problem hiding this comment.
🟠 High — The driver forwards enableHttp2 to native kernel packages that are all still pinned to 1.4.0 in package.json. Per the reviewers, that release has no such field, so enableHttp2: false would likely be silently dropped. Bump KERNEL_REV, the eight platform pins and the lockfile to the kernel release with the option, then regenerate the bindings. Alternatively, land this change together with that bump.
🔀 Found by both reviewers · confirmed by the judge
There was a problem hiding this comment.
Duplicate of the release prerequisite at #626 (comment). This PR is blocked on the kernel #483 release; KERNEL_REV, all eight platform pins and the lockfile must be updated, and native/kernel/index.* regenerated with npm run build:native, before merge.
There was a problem hiding this comment.
Still open at 0d563d5: the kernel pins, KERNEL_REV, lockfile and regenerated bindings must ship with this change before merge.
| * to SEA. | ||
| */ | ||
| enableGeoSpatialSupport?: boolean | ||
| /** Negotiate HTTP/2 over HTTPS by default. False or a configured proxy forces HTTP/1.1. */ |
There was a problem hiding this comment.
🔵 Low — native/kernel/index.d.ts carries the header "auto-generated by NAPI-RS" but now has a hand-added enableHttp2 field. The pinned 1.4.0 binary likely lacks that field. Revert the hunk and regenerate with npm run build:native when the kernel pins are bumped.
🔀 Found by Claude Opus 5.5 · confirmed by the judge
There was a problem hiding this comment.
Duplicate of the release prerequisite at #626 (comment). This PR is blocked on the kernel #483 release; KERNEL_REV, all eight platform pins and the lockfile must be updated, and native/kernel/index.* regenerated with npm run build:native, before merge.
Signed-off-by: Aakash Saravanan <aakash.saravanan@databricks.com>
Signed-off-by: Aakash Saravanan <aakash.saravanan@databricks.com>
Signed-off-by: Aakash Saravanan <aakash.saravanan@databricks.com>
Signed-off-by: Aakash Saravanan <aakash.saravanan@databricks.com>
Signed-off-by: Aakash Saravanan <aakash.saravanan@databricks.com>
Signed-off-by: Aakash Saravanan <aakash.saravanan@databricks.com>
Signed-off-by: Aakash Saravanan <aakash.saravanan@databricks.com>
0d563d5 to
98ec0d6
Compare
There was a problem hiding this comment.
🔀 Cross-reviewed: two independent reviews (Claude Opus 5.5 · GPT-6.1 Sol), checked by a judge model (Claude Sonnet 5.5).
Verdict: 1 High · 1 Low
Needs changes before merge: 1 medium, 1 low. The TS forwarding and validation are correct and tested. However, the native typings were edited by hand and the published binding doesn't support the field yet, so enableHttp2: false would be silently ignored.
| * to SEA. | ||
| */ | ||
| enableGeoSpatialSupport?: boolean | ||
| /** Negotiate HTTP/2 over HTTPS by default. False or a configured proxy forces HTTP/1.1. */ |
There was a problem hiding this comment.
🟠 High — native/kernel/index.d.ts is NAPI-RS generated ("auto-generated by NAPI-RS"), but enableHttp2 was added by hand while the kernel packages in package.json stay at 1.4.0. Regenerate the file from the pinned build, and bump KERNEL_REV, the platform pins and the lockfile in the same change.
🔀 Found by both reviewers · confirmed by the judge
|
|
||
| - Avoid intermediate decimal strings when materializing Arrow DECIMAL values with safe unscaled integers, on both backends. | ||
| - Reduce Arrow row materialization overhead on both backends by reading vectors directly and resolving scalar conversions once per batch. Object and array row values are unchanged. | ||
| - Kernel HTTPS traffic negotiates HTTP/2 with HTTP/1.1 fallback. Set `enableHttp2: false` to force HTTP/1.1. Configured proxies also force HTTP/1.1. |
There was a problem hiding this comment.
🔵 Low — The changelog entry presents HTTP/2 control as shipped, but the pinned 1.4.0 native packages don't support the field. State the required kernel release and native package bump, or land the pin bump with this entry.
🔀 Found by Claude Opus 5.5 · confirmed by the judge
Feature or gap
Expose HTTP/2 negotiation control for kernel connections.
What this PR addresses
Forward the kernel-only boolean
enableHttp2option, preserving explicitfalse. Omission preserves the native default. Configured proxies keep kernel HTTPS on HTTP/1.1.Dependencies
Blocked on the merged release of kernel #483. Update
KERNEL_REV, all eight platform package pins and the lockfile, then runnpm run build:nativeand commit the generated binding files from that release. Current 1.4.0 artifacts do not provide the new field; these updates must land before this driver PR merges.Tests and validation
Connection-option unit tests cover the omitted default, true/false forwarding and rejection of a non-boolean value. Prettier checks the committed documentation and source. Compatibility and large-result measurements used earlier local builds. Published-artifact and scheduled verification remain open.
This pull request and its description were written by Isaac.