Repository navigation
Conversation
|
/ug-review This comment was generated with GitHub MCP. |
UG review recommendationRECOMMENDATION: APPROVE Reasons:
Findings considered: 2 (severities: low: 1, medium: 1); see the inline review comments. Advisory only: this recommendation never approves or merges the pull request. The |
Polly AI ReviewBlocking issuesNone found. Security vulnerabilitiesNone found. Non-blocking notes
ApproachThe shared helper is the right location, and reusing SummaryDiff size (computed): 3 files; +57 / -0 lines (57 changed text lines); 0 binary files.
Shares use additions + deletions, including generated text and lockfiles. Binary files have no line count. Tests include fixtures/helpers under test paths and colocated test/spec files; categories are path-based, not coverage measurements. ChangesThe change adds hover-dismissal readiness before shared VS Code clicks, focused component coverage, and documentation of its limits. The implementation is proportional to the reported interception failure. No concrete duplication warrants removal. TestsTest-by-test assessment
All three added cases passed in offline execution. Removing the helper change caused the delayed-dismissal and persistent-hover cases to fail. Existing VS Code journeys already cover model selection, completed tasks, and correlated inference requests/responses; another live journey is unnecessary. Actual tooltip-selector matching, browser visibility semantics, and dismissal timing remain unverified. Live integration and lint were not run. To verify the native behavior, use the pinned VS Code build and existing Claude-to-GPT journey: reproduce the obstructing tooltip, confirm it disappears before the click, and confirm model switching and the subsequent task complete. ScopeAll changes support the hover-interception fix or its verification and documentation. No unrelated changes were found. Automated review by Polly · workflow run |
|
Polly's notes concern the superseded hover wrapper. 20ccca2 removes that polling loop and its mock tests; pointer movement remains immediately before the original single Playwright click. Native actionability uses the existing step budget, with no second wait layered on top. The README records the remaining limit: an unavailable click can take up to the step budget before the existing picker screen-change recovery runs. This keeps the fix to one native timeout argument rather than adding caller-deadline plumbing or replaying an action. Native CI remains pending. This comment was generated with GitHub MCP. |
|
Native evidence is now captured in artifact14642086286: the model-button center (1266.56,813) is inside the neighboring hover bounds (1207..1437.61,811..838), with the original2s error and immediate screenshot retained. Three of four Linux VS Code cases passed; the fourth reproduced this exact pre-existing interception. Pinned upstream source also confirms the primary model-name button is focusable and handles Enter/Space. The smaller native-keyboard fix is being validated in #1805. Holding this diagnostic PR without automerge and canceling its redundant CI to reduce provider pressure; if the small fix passes native validation, this PR can be closed as superseded while retaining its evidence and branch for audit. This comment was generated with GitHub MCP. |
|
Closing as superseded by the smaller real fix #1805. Its exact final head d6468c4 passed all4 native VS Code cases on both Linux and Windows, including readable Claude/GPT model selection and completed file-task answers. The generic capture code is therefore not needed to solve this flake. Diagnostic evidence remains preserved in artifact14642086286, the discussion and this pushed branch. It established that the adjacent approval tooltip covers the model button's center; the native keyboard fix avoids that pointer overlap while retaining the original2s recovery. This PR will remain unmerged. This comment was generated with GitHub MCP. |
What did you change, and why?
The VS Code Claude-to-GPT journey failed opening the model picker in CI 44751086897. Playwright found the button visible, enabled and stable, but a
Use configured approval settingshover intercepted pointer events. Existing screenshots are taken only after the whole journey fails, when that overlay may already be gone; clicks consumed by the picker's screen-change recovery lose their original error details.Keep the original two-second click timeout and picker recovery, and capture each failed click immediately: screenshot, action, elapsed time, native error, target bounds, visible hover text/bounds and recognized screen. JSON goes through the existing redacted evidence writer. Read hover data before target lookup so it survives a disappeared target. Failed metadata lookup retains core evidence with an exception class; failed evidence writing records only its error class and preserves the original click exception. Failure screenshot and target lookup each have a 500ms limit; ordinary screenshots retain their default timeout. Document that these post-timeout observations are not atomic.
How do you know it works?
/usr/bin/python3.12 -m unittest tests.test_vscode_harness -v: four real-helper component checks passed, covering successful short clicks without failure evidence, retained geometry/error/screenshot data, a disappeared target keeping core/hover evidence, and evidence-write failure preserving the original click exception. Tests verify the capture limits and the original single click. Browser/file-writing boundaries are substituted; these checks do not prove native tooltip geometry or live artifact delivery.Python compilation,
git diff --checkand commit/push secret scans passed. Ruff/full pytest are unavailable locally; PR CI covers those and native VS Code.tests/README.mdis unchanged. This adds diagnostics, not a claim to fix the underlying tooltip flake. The original short deadline is required so the picker can resample a changed screen within its existing step budget.Checklist before requesting review
/ug-reviewand address the comments. Supported review labels trigger the workflow because the connector appends a footer to comments. The final diagnostic-scope UG review recommended APPROVE; both final-scope threads are addressed and resolved. Secondary Polly review remains pending./integration-testwill not be commented, as instructed.