Repository navigation
Conversation
|
/ug-review This comment was generated with GitHub MCP. |
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 1 selected item(s). |
UG review recommendationRECOMMENDATION: APPROVE Reasons:
Complete review of 1 files; no findings. Advisory only: this recommendation never approves or merges the pull request. The |
Polly AI ReviewBlocking issuesNone identified. Security vulnerabilitiesNone identified. Non-blocking notes
ApproachThe approach is sound. Native Enter activation avoids pointer interception without forced clicks, DOM mutation, additional waits, or retries. The locator remains scoped to the existing first split button. SummaryDiff size (computed): 2 files; +10 / -1 lines (11 changed text lines); 0 binary files.
Shares use additions + deletions, including generated text and lockfiles. Binary files have no line count. Tests include fixtures/helpers under test paths and colocated test/spec files; categories are path-based, not coverage measurements. ChangesThe picker-opening helper switches from a mouse click to Enter on the visible model-name button. Supporting documentation explains the choice. The action timeout, recovery logic, and other mouse actions remain unchanged. The change is proportional to the reported tooltip interception. No concrete reduction is needed. TestsTest-by-test assessmentNo test cases are added or removed; the diff modifies a shared helper and test documentation.
Existing scenarios are sufficient in design; native execution is needed to establish that Enter works with the pinned UI and tooltip overlap. No tests were run during this review. Linux/Windows results and linked upstream/artifact evidence remain unverified. Request/response assertions do not establish downstream usage attribution. Both trusted review policies were read, and the frozen diff checksum matched. The referenced To verify, reproduce the adjacent approval tooltip overlap, activate the model-name button with Enter, select the expected readable models, and complete both file tasks in the existing model-switch scenario on Linux and Windows. ScopeBoth changed files support the single outcome of avoiding tooltip-intercepted picker clicks. No unrelated changes or unresolved scope questions were found. Automated review by Polly · workflow run |
|
Native validation on d6468c4 is complete on both platforms: Linux job136383502134 and Windows job136383502057 each passed all4 existing VS Code cases (zero failures/skips). The same-window switch artifacts show readable For Polly's validation note: these are real pinned Linux/Windows UI runs, not mocked activation. I did not artificially force an overlay in the passing runs. The original overlap is independently established by the linked failed-run geometry/screenshot, and the exact pinned source proves that Enter invokes the model-name button's native handler without pointer hit testing. This avoids adding a separate synthetic UI scenario or weakening any existing task assertion. This comment was generated with GitHub MCP. |
What did you change, and why?
The model-picker mouse click intermittently hits a neighboring
Use configured approval settingstooltip. Native evidence records the model button center(1266.56, 813)inside the hover rectangle(1207..1437.61, 811..838), while Playwright correctly refuses the intercepted click.Open only the visible primary model-name button with its native Enter handler. VS Code 1.144.0 renders that primary button as focusable and registers Enter/Space to open the model-name picker. The outer split container is a non-tabbable group, so target its visible
.model-picker-namechild. Keep the original two-second action timeout, screen-change recovery, other mouse actions, model-selection checks and completed inference assertions.How do you know it works?
Final head d6468c4 passed all four existing VS Code cases on each platform: Linux and Windows, eight passes with no failures or skips. Saved switch artifacts show
Models, Claude Haiku 4.5andModels, GPT 6 Luna, completed native file-read answers without errors, and the expected Claude/GPT route/model records. Existing assertions validate hidden file values and correlated successful responses.Python compilation,
git diff --checkand commit/push secret scans passed. Passing runs do not deliberately force tooltip overlap; the separate failed-run evidence establishes that geometry, and the pinned handler proves keyboard activation avoids pointer hit testing.tests/README.mdis unchanged.The diagnostic PR #1804 is closed unmerged as superseded by this smaller fix; its artifact and pushed branch preserve the investigation evidence.
Checklist before requesting review
/ug-reviewand address the comments. UG review recommended APPROVE with zero findings; Polly found no blocking/security issues and its native validation note is answered with both platform results./integration-testwill not be commented, as instructed.