Repository navigation
fix(cloud): show notices before rejecting an unsupported iOS device o… - #289
Merged
Merged
Conversation
…r version The iOS device/version check ran before the DB-driven notices were rendered, while the Android check ran after them (both date from the initial commit). So a run that pinned a removed iOS device or version was rejected without the notice that explains the removal: on 2 Nov 2026 the removed-ios-17-2026-11-02 and removed-ios-devices-2026-11-02 notices never showed in the CLI, only the bare "not supported" error. The iOS check now runs right after the notices, next to the Android one. Nothing between the two reads the validation result, and the notice context uses the raw flags, so only the output order changes. Checked against dev: --ios-device iphone-15 and --ios-device iphone-14 --ios-version 17 now print their removed notice, then the same error. The MCP tool (dcd_run_cloud_test) renders no notices, so it is unchanged.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
1 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…r version
The iOS device/version check ran before the DB-driven notices were rendered, while the Android check ran after them (both date from the initial commit). So a run that pinned a removed iOS device or version was rejected without the notice that explains the removal: on 2 Nov 2026 the removed-ios-17-2026-11-02 and removed-ios-devices-2026-11-02 notices never showed in the CLI, only the bare "not supported" error.
The iOS check now runs right after the notices, next to the Android one. Nothing between the two reads the validation result, and the notice context uses the raw flags, so only the output order changes. Checked against dev: --ios-device iphone-15 and --ios-device iphone-14 --ios-version 17 now print their removed notice, then the same error.
The MCP tool (dcd_run_cloud_test) renders no notices, so it is unchanged.
What & why
Type of change
fix— bug fixfeat— new featureperf— performance improvementrefactor— code change that's neither a fix nor a featuredocs— documentation onlychore/ci/build/test— tooling, no user-facing change!or PR notes aBREAKING CHANGE:)Checklist
pnpm lintpassespnpm typecheckpassespnpm buildpassesCHANGELOG.md(release-please handles this)README.md/STYLE_GUIDE.mdupdated if behaviour or output changedHow to test