Skip to content

fix(cloud): show notices before rejecting an unsupported iOS device o… #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
finalerock44 merged 1 commit into from
Nov 2, 2026
Merged

fix(cloud): show notices before rejecting an unsupported iOS device o… #289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/commands/cloud.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,11 +490,6 @@ export const cloudCommand = defineCommand({
throw new CliError('You must provide a flow file');
}

deviceValidationService.validateiOSDevice(iOSVersion, iOSDevice, compatibilityData, {
debug,
logger: (m: string) => out(m),
});

// Render DB-driven notices (deprecation/warn/info/marketing) the API
// returned with the compatibility data. Replaces the previously hardcoded
// iOS-16 deprecation warning — that is now a seeded notice gated on the
Expand Down Expand Up @@ -529,6 +524,13 @@ export const cloudCommand = defineCommand({
learnMoreUrl: n.learnMoreUrl,
}));

// Validated after the notices, so a notice aimed at a removed device or
// OS version (e.g. removed-ios-17-2026-11-02) is shown before the
// rejection it explains.
deviceValidationService.validateiOSDevice(iOSVersion, iOSDevice, compatibilityData, {
debug,
logger: (m: string) => out(m),
});
deviceValidationService.validateAndroidDevice(
androidApiLevel,
androidDevice,
Expand Down
Loading