Repository navigation
Gate Rust dead-code Cargo execution behind command trust - #156
Merged
alxxjohn merged 2 commits intoAug 24, 2026
Merged
Conversation
alxxjohn
deleted the
alexj/propose-fix-for-rust-dead-code-vulnerability
branch
August 24, 2026 23:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
cargo checkbased solely on repository config, allowing untrusted PRs to run build scripts or proc-macros and potentially exfiltrate secrets.Description
trust.GuardConfigCommand("quality_rules.dead_code", "cargo check")inrustToolchainDeadCodeFindings, and return a diagnostic when command execution is denied.TestRustToolchainDeadCodeRequiresConfigCommandTrustinquality_rust_toolchain_dead_code_test.gothat verifies the default-deny policy produces the expected trust diagnostic.Testing
go test ./internal/codeguard/checks/quality(unit tests for the modified package passed).go test ./...(full test suite in the repository completed successfully).gofmt -w internal/codeguard/checks/quality/quality_rust_toolchain_dead_code.go internal/codeguard/checks/quality/quality_rust_toolchain_dead_code_test.go(formatting applied with no issues).git diff --check(no whitespace or diff errors reported).Codex Task