Skip to content

Gate Rust dead-code Cargo execution behind command trust #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alxxjohn merged 2 commits into from
Aug 24, 2026
Merged

Gate Rust dead-code Cargo execution behind command trust #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0440f94
fix: gate Rust dead-code Cargo execution
alxxjohn Aug 24, 2026
427c6f6
fix: support Go 1.23 in Rust dead-code test
alxxjohn Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions internal/codeguard/checks/quality/quality_rust_toolchain_dead_code.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import (

"github.com/devr-tools/codeguard/internal/codeguard/checks/support"
"github.com/devr-tools/codeguard/internal/codeguard/core"
"github.com/devr-tools/codeguard/internal/codeguard/trust"
)

const (
Expand Down Expand Up @@ -75,6 +76,9 @@ func rustToolchainDeadCodeFindings(ctx context.Context, env support.Context, tar
return nil
}
level := toolchainDeadCodeLevel(cfg)
if err := trust.GuardConfigCommand("quality_rules.dead_code", "cargo check"); err != nil {
return []core.Finding{rustToolchainDeadCodeDiagnostic(env, level, err.Error())}
}
issues, err := rustToolchainDeadCodeIssues(ctx, env, target, cfg)
findings := make([]core.Finding, 0, len(issues)+1)
for _, issue := range issues {
Expand Down
28 changes: 28 additions & 0 deletions internal/codeguard/checks/quality/quality_rust_toolchain_dead_code_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,43 @@
package quality

import (
"context"
"os"
"path/filepath"
"strings"
"testing"

"github.com/devr-tools/codeguard/internal/codeguard/checks/support"
"github.com/devr-tools/codeguard/internal/codeguard/core"
"github.com/devr-tools/codeguard/internal/codeguard/trust"
)

func TestRustToolchainDeadCodeRequiresConfigCommandTrust(t *testing.T) {
originalPolicy := trust.Current()
t.Cleanup(func() { trust.Set(originalPolicy) })
trust.Set(trust.Policy{})

enabled := true
env := support.Context{
Config: core.Config{Checks: core.CheckConfig{QualityRules: core.QualityRulesConfig{
DeadCode: core.QualityDeadCodeConfig{Enabled: &enabled, Mode: "toolchain"},
}}},
NewFinding: func(input support.FindingInput) core.Finding {
return core.Finding{RuleID: input.RuleID, Level: input.Level, Message: input.Message}
},
}
target := core.TargetConfig{Name: "crate", Path: t.TempDir(), Language: "rust"}

findings := rustToolchainDeadCodeFindings(context.Background(), env, target)

if len(findings) != 1 {
t.Fatalf("findings = %+v, want one trust diagnostic", findings)
}
if !strings.Contains(findings[0].Message, "refusing to run config-supplied command") {
t.Fatalf("message = %q, want config command trust error", findings[0].Message)
}
}

func TestParseCargoDeadCodeDiagnostics(t *testing.T) {
output := `{"reason":"compiler-message","message":{"level":"error","message":"function ` + "`unused_helper`" + ` is never used","code":{"code":"dead_code"},"spans":[{"file_name":"src/lib.rs","line_start":3,"column_start":4,"is_primary":true}]}}` + "\n" +
`{"reason":"compiler-message","message":{"level":"warning","message":"unreachable statement","code":{"code":"unreachable_code"},"spans":[{"file_name":"src/lib.rs","line_start":8,"column_start":5,"is_primary":true}]}}` + "\n" +
Expand Down
Loading