Repository navigation
fix(submit): handle emoji sequences, ?!, .git.git and ### in descriptions - #203
Merged
jamesconwaydev merged 1 commit intoNov 6, 2026
Conversation
…ions A zero-width joiner between two emoji now survives the invisible- character strip and the joined sequence counts as one emoji, so a family emoji no longer counts as three in a row. A trailing run of punctuation that has a question mark now ends in one ?, so a question stays a question. Anything else still ends in a full stop. A repo link ending in .git.git is rejected; GitHub never names a repo that way. A ### line typed into the description used to cut it short without a word. The submitter now gets an error that says so.
jamesconwaydev
approved these changes
Nov 6, 2026
jamesconwaydev
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Keeping the ZWJ only between two emoji means it still can't split a blocked word. I'm happy for a trailing question mark to stay a question mark.
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Closes #48. One fix per bullet in the issue:
_strip_invisiblekeeps a U+200D that sits between two emoji (a variation selector before it is fine). The run check counts a joined emoji as part of the one before it, so 👨👩👧 is one emoji, not three. A ZWJ anywhere else is still stripped, so it can't split a blocked word. The stored text re-cleans to itself, sovalidate_dataagrees.?!?!at the end. A trailing punctuation run that has a?now ends in a single?, and anything else still ends in.. So "Why write YAML by hand?!?!" becomes "Why write YAML by hand?", and "Toolkit!!!" still becomes "Toolkit.". This also changes a plain trailing?, which used to become.. Say if you'd rather keep the full stop everywhere and just collapse the run.owner/repo.git.gitis rejected as a bad link. The first.gitis now stripped case-insensitively, and a second one fails, since GitHub never names a repo that way.### Repositoryin a description. In the form,### Checklistalways comes right after### Description. If any other heading comes first, it was typed into the answer, and the submitter now gets "Your description has a line starting with ###, which cuts it short." Extra headings after the checklist are still ignored, astest_extra_and_duplicate_headingsexpects. Reports are unchanged.Every new test fails on
mainand passes here.Checks
python3 -m unittest discover -s scripts -t .passesnpm --prefix site testpasses (if you touchedsite/)npx prettier --check .passesdata/entries.jsonby hand (submissions go through the form)