Skip to content

fix(admin): keep setup_repo.sh in line with main and runnable on macOS - #252

Merged
jamesconwaydev merged 2 commits into
mainfrom
admin-ruleset-match-live
Nov 6, 2026
Merged

jamesconwaydev merged 2 commits into
mainfrom
admin-ruleset-match-live

Conversation

@jamesconwaydev

@jamesconwaydev jamesconwaydev commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Two fixes to setup_repo.sh:

  • Code-owner review and last-push approval. I turned both on for main earlier today (with data/entries.json left unowned so bot submissions still merge). The script still wrote them as false, so a re-run would have quietly undone that. It now matches the live ruleset.
  • macOS. fix(admin): let setup_repo.sh finish cleanly when the org blocks approvals #251 read the ruleset IDs with mapfile, which bash 3.2 (still the macOS default) doesn't have. CI passed because it runs bash 5. On a Mac the script failed at that line. It's a plain read loop now, and test_setup_repo passes under bash 3.2 too.

@jamesconwaydev jamesconwaydev changed the title fix(admin): stop setup_repo.sh turning code-owner review back off fix(admin): keep setup_repo.sh in line with main and runnable on macOS Nov 6, 2026
@jamesconwaydev
jamesconwaydev merged commit 1861e9e into main Nov 6, 2026
8 checks passed
@jamesconwaydev
jamesconwaydev deleted the admin-ruleset-match-live branch November 6, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant