Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions scripts/admin/setup_repo.sh
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ RULESET=$(cat <<'J'
"parameters": {
"required_approving_review_count": 1,
"dismiss_stale_reviews_on_push": true,
"require_code_owner_review": false,
"require_last_push_approval": false,
"require_code_owner_review": true,
"require_last_push_approval": true,
"required_review_thread_resolution": false,
"require_extra_approval_for_unattributed_changes": true
}
Expand Down Expand Up @@ -106,7 +106,11 @@ J
upsert_ruleset() {
local ids
# This repo's own rulesets only: an org ruleset with the same name can't be updated from here.
mapfile -t ids < <(gh api --paginate "repos/$REPO/rulesets?includes_parents=false" \
# A read loop, not mapfile: macOS still ships bash 3.2.
ids=()
while IFS= read -r id; do
[ -n "$id" ] && ids+=("$id")
done < <(gh api --paginate "repos/$REPO/rulesets?includes_parents=false" \
--jq ".[] | select(.name==\"$1\") | .id" | sort -n)
if [ "${#ids[@]}" -gt 1 ]; then
# Deleting a ruleset is a call to make by hand, so update the oldest and say which others exist.
Expand Down
Loading