Skip to content

code refactor, updated composer, docs, workflow, tests - #15

Open
bidi47 wants to merge 4 commits into
2.0from
upgrade
Open

bidi47 wants to merge 4 commits into
2.0from
upgrade

Conversation

@bidi47

@bidi47 bidi47 commented Nov 10, 2026 •

Copy link
Copy Markdown
Member
  • updated composer
    • added PHP 8.6
    • updated phpunit/phpunit: ^12.5
  • updated docs
    • added v2
    • updated readme, security, changelog
  • code refactoring
  • updated tests, phpstan from level 5 to 8

Signed-off-by: bidi <bidi@apidemia.com>
Signed-off-by: bidi <bidi@apidemia.com>
@codecov

codecov Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (98a69c5) to head (76e32c9).

Additional details and impacted files
@@             Coverage Diff             @@
##                 2.0       #15   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        44        62   +18     
===========================================
  Files              7         7           
  Lines             99       134   +35     
===========================================
+ Hits              99       134   +35     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bidi47
bidi47 requested a review from alexmerlin November 10, 2026 16:20

@alexmerlin alexmerlin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the 2.0 branch protected and remove 2,0.

Comment thread composer.json
"psr/container": "^1.1 || ^2.0"
},
"require-dev": {
"doctrine/orm": "^2.9 || ^3.0",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doctrine components are used in src/Factory/AttributedRepositoryFactory.php.
So. why did this move under require-dev? Is it to make the package usable without Doctrine?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's to run some tests (dev mode), otherwise you need it if you use the repository factory
if you only use #[Inject], composer won't install ORM, DBAL and their dependencies

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've had this discussion before with the team - let's keep it open until @arhimede confirms either way.

Comment thread .github/workflows/static-analysis.yml Resolved
@alexmerlin

Copy link
Copy Markdown
Member

Basically, we're going to release a 2.0 version just to add and remove two minor PHP version?

Signed-off-by: bidi <bidi@apidemia.com>
Comment thread .laminas-ci.json Resolved
Signed-off-by: bidi <bidi@apidemia.com>
@bidi47 bidi47 linked an issue Nov 13, 2026 that may be closed by this pull request
@bidi47
bidi47 requested a review from alexmerlin November 16, 2026 13:49

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump PHP 8.6

2 participants