Repository navigation
Conversation
Signed-off-by: bidi <bidi@apidemia.com>
Signed-off-by: bidi <bidi@apidemia.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.0 #15 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 44 62 +18
===========================================
Files 7 7
Lines 99 134 +35
===========================================
+ Hits 99 134 +35 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alexmerlin
left a comment
There was a problem hiding this comment.
Please make the 2.0 branch protected and remove 2,0.
| "psr/container": "^1.1 || ^2.0" | ||
| }, | ||
| "require-dev": { | ||
| "doctrine/orm": "^2.9 || ^3.0", |
There was a problem hiding this comment.
Doctrine components are used in src/Factory/AttributedRepositoryFactory.php.
So. why did this move under require-dev? Is it to make the package usable without Doctrine?
There was a problem hiding this comment.
it's to run some tests (dev mode), otherwise you need it if you use the repository factory
if you only use #[Inject], composer won't install ORM, DBAL and their dependencies
There was a problem hiding this comment.
We've had this discussion before with the team - let's keep it open until @arhimede confirms either way.
|
Basically, we're going to release a |
Signed-off-by: bidi <bidi@apidemia.com>
Signed-off-by: bidi <bidi@apidemia.com>
Uh oh!
There was an error while loading. Please reload this page.