Repository navigation
code refactor, updated composer, docs, workflow, tests #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bidi47
wants to merge
4
commits into
2.0
Choose a base branch
from
upgrade
base: 2.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| { | ||
| "ignore_php_platform_requirements": { | ||
| "8.6": true | ||
| }, | ||
| "backwardCompatibilityCheck": true | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,96 @@ | ||
| ## 1.0.0 - 2024-06-06 | ||
| # Changelog | ||
|
|
||
| Initial tagged release | ||
| All notable changes to this project are documented in this file. | ||
|
|
||
| ## 2.0.0 - TBD | ||
|
|
||
| ### Added | ||
|
|
||
| - PHP 8.6 support | ||
| - `RuntimeException::notInstantiable()`, `dependencyNotInstantiable()`, `argumentCountMismatch()`, `invalidService()` and `missingPackage()` | ||
| - `InvalidArgumentException::emptySegment()` | ||
| - Documentation for version 2, including an upgrade guide | ||
|
|
||
| ### Changed | ||
|
|
||
| - `doctrine/orm` moved from `require` to `suggest`; applications using `AttributedRepositoryFactory` must require it, and versions below 2.9 or from 4.0 conflict | ||
| - `psr/container` requirement raised to `^1.1 || ^2.0` | ||
| - `AttributedServiceFactory::readKeysFromArray()` takes the full service key as its third parameter | ||
| - PHPUnit 12.5 and PHPStan level 8; the test suite fails on notices, warnings, deprecations and risky tests | ||
|
|
||
| ### Deprecated | ||
|
|
||
| - Nothing. | ||
|
|
||
| ### Removed | ||
|
|
||
| - `AttributedServiceFactory::$originalKey` | ||
|
|
||
| ### Fixed | ||
|
|
||
| - Requesting an abstract class, an enum or a class with a non-public constructor throws `RuntimeException` instead of a PHP `Error` | ||
| - An unregistered dependency that cannot be instantiated without arguments throws `RuntimeException` instead of `ArgumentCountError` or `Error` | ||
| - The number of `#[Inject]` entries is checked against the constructor; extra entries were silently ignored | ||
| - Empty dot-notation segments throw `InvalidArgumentException` instead of reading the `''` key | ||
| - `AttributedRepositoryFactory` checks the type of the entity manager service | ||
| - `AttributedRepositoryFactory` names the missing package when `doctrine/orm` is not installed | ||
|
|
||
| ## 1.4.1 - 2026-09-16 | ||
|
|
||
| ### Fixed | ||
|
|
||
| - FAQ menu entry ([#14](https://github.com/dotkernel/dot-dependency-injection/pull/14)) | ||
|
|
||
| ## 1.4.0 - 2026-09-16 | ||
|
|
||
| ### Changed | ||
|
|
||
| - `#[Entity]` targets classes and `#[Inject]` targets methods only ([#13](https://github.com/dotkernel/dot-dependency-injection/pull/13)) | ||
| - Documentation expanded with the "Attributes vs. factories" and FAQ pages ([#13](https://github.com/dotkernel/dot-dependency-injection/pull/13)) | ||
|
|
||
| ### Removed | ||
|
|
||
| - PHP 8.2 support ([#13](https://github.com/dotkernel/dot-dependency-injection/pull/13)) | ||
|
|
||
| ### Fixed | ||
|
|
||
| - A configuration value of `null` was treated as a missing key ([#13](https://github.com/dotkernel/dot-dependency-injection/pull/13)) | ||
| - Dot-notation paths continuing past a scalar were silently truncated ([#13](https://github.com/dotkernel/dot-dependency-injection/pull/13)) | ||
| - `AttributedRepositoryFactory` returned a repository of the wrong class when the entity did not declare `repositoryClass` ([#13](https://github.com/dotkernel/dot-dependency-injection/pull/13)) | ||
| - An `#[Entity]` attribute naming a missing class was not reported ([#13](https://github.com/dotkernel/dot-dependency-injection/pull/13)) | ||
|
|
||
| ## 1.3.0 - 2025-10-30 | ||
|
|
||
| ### Added | ||
|
|
||
| - PHP 8.4 and 8.5 support ([#11](https://github.com/dotkernel/dot-dependency-injection/pull/11)) | ||
|
|
||
| ### Removed | ||
|
|
||
| - PHP 8.1 support ([#11](https://github.com/dotkernel/dot-dependency-injection/pull/11)) | ||
|
|
||
| ## 1.2.0 - 2025-03-04 | ||
|
|
||
| ### Changed | ||
|
|
||
| - Psalm replaced with PHPStan ([#9](https://github.com/dotkernel/dot-dependency-injection/pull/9)) | ||
|
|
||
| ## 1.1.1 - 2025-01-28 | ||
|
|
||
| ### Changed | ||
|
|
||
| - Psalm 6.x ([#7](https://github.com/dotkernel/dot-dependency-injection/pull/7)) | ||
|
|
||
| ## 1.1.0 - 2024-10-22 | ||
|
|
||
| ### Added | ||
|
|
||
| - PHP 8.4 support ([#5](https://github.com/dotkernel/dot-dependency-injection/pull/5)) | ||
|
|
||
| ### Changed | ||
|
|
||
| - `laminas/laminas-coding-standard` 3.x | ||
|
|
||
| ## 1.0.0 - 2024-06-07 | ||
|
|
||
| Initial tagged release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doctrine components are used in
src/Factory/AttributedRepositoryFactory.php.So. why did this move under
require-dev? Is it to make the package usable without Doctrine?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's to run some tests (dev mode), otherwise you need it if you use the repository factory
if you only use #[Inject], composer won't install ORM, DBAL and their dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've had this discussion before with the team - let's keep it open until @arhimede confirms either way.