Repository navigation
Return an error tuple when parsing empty input - #154
Merged
Merged
Conversation
Keep loads() raising its existing ValueError while parse() follows its documented tuple-result contract for empty strings and bytes. Prepared with AI assistance; contributor review is required before upload.
Owner
|
Good catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153.
parse('')raises ValueError despite its documented error-tuple contract. Return the error tuple for empty input instead.loads()continues raising the same ValueError through its existing error handling.One regression checks empty text and bytes; both fail before the fix. Existing tests cover loads() rejection and other parse errors.
All 97 tests pass on Windows/Python 3.14 and Ubuntu/Python 3.10. Windows line coverage is 100%; Ruff, pylint, mypy, formatting and package builds pass. Other supported interpreters and hosted CI were not run locally.
Prepared with AI assistance. The contributor confirmed reviewing and vetting this commit before upload.