Skip to content

Return an error tuple when parsing empty input #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpranke merged 1 commit into from
Nov 2, 2026
Merged

Return an error tuple when parsing empty input #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion json5/lib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ def parse(
s = s.decode(encoding)

if not s:
raise ValueError('Empty strings are not legal JSON5')
return None, 'Empty strings are not legal JSON5', 0
start = start or 0
parser = Parser(s, '<string>', pos=start)
ast, err, pos = parser.parse(
Expand Down
8 changes: 8 additions & 0 deletions tests/lib_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,6 +533,14 @@ def check(self, s, obj, err, pos, consume_trailing=True, start=0):
self.assertEqual(err, actual_err)
self.assertEqual(pos, actual_pos)

def test_parse_empty_input(self):
for source in ('', b''):
with self.subTest(source=source):
self.assertEqual(
json5.parse(source),
(None, 'Empty strings are not legal JSON5', 0),
)

def test_parse(self):
self.check('4', 4, err=None, pos=1)
self.check('4 ', 4, err=None, pos=2)
Expand Down