Repository navigation
Drop support for Node versions below 22.12 - #1110
Merged
NullVoxPopuli merged 1 commit intoNov 12, 2026
Merged
NullVoxPopuli merged 1 commit into
NullVoxPopuli merged 1 commit into
Conversation
Node 22.12 is the first Node 22 release with `require(esm)` on by default. The smoke test app floats to current testem, which needs `require(esm)` for execa 9, and to packages whose engines exclude Node 18. CI now runs on Node 22, and the smoke test matrices run on 22, 24, and 26. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kategengler
approved these changes
Nov 12, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1110 +/- ##
=======================================
Coverage 95.54% 95.54%
=======================================
Files 21 21
Lines 516 516
=======================================
Hits 493 493
Misses 23 23 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change:
engines.nodeis now>= 22.12.0. Node 22.12 is the first Node 22 release withrequire(esm)on by default.The Node 18 CI jobs fail on every new PR (for example #1109). The smoke test app floats to current packages:
ERR_REQUIRE_ESMfromtestem/node_modules/execa/index.js.mktemp@2.0.4: The engine "node" is incompatible with this module. Expected version "20 || 22 || 24 || 26". Got "18.20.8".Changes:
engines.nodeis>= 22.12.0inpackage.jsonand in the smoke test app.pnpm testpasses locally on Node 22.22.0 (153 tests).This PR needs a breaking-change label for release-plan. The agent account cannot add labels.
🤖 Generated with Claude Code