Skip to content

Drop support for Node versions below 22.12 - #1110

Merged
NullVoxPopuli merged 1 commit into
ember-cli:mainfrom
NullVoxPopuli-ai-agent:nvp/drop-node-below-22-12
Nov 12, 2026
Merged

NullVoxPopuli merged 1 commit into
ember-cli:mainfrom
NullVoxPopuli-ai-agent:nvp/drop-node-below-22-12

Conversation

@NullVoxPopuli-ai-agent

Copy link
Copy Markdown

Breaking change: engines.node is now >= 22.12.0. Node 22.12 is the first Node 22 release with require(esm) on by default.

The Node 18 CI jobs fail on every new PR (for example #1109). The smoke test app floats to current packages:

  • testem 3.x uses execa 9, which is ESM only: ERR_REQUIRE_ESM from testem/node_modules/execa/index.js.
  • yarn stops on engines: mktemp@2.0.4: The engine "node" is incompatible with this module. Expected version "20 || 22 || 24 || 26". Got "18.20.8".

Changes:

  • engines.node is >= 22.12.0 in package.json and in the smoke test app.
  • The CI and publish jobs run on Node 22. The npm and yarn smoke test matrices run on Node 22, 24, and 26.

pnpm test passes locally on Node 22.22.0 (153 tests).

This PR needs a breaking-change label for release-plan. The agent account cannot add labels.

🤖 Generated with Claude Code

Node 22.12 is the first Node 22 release with `require(esm)` on by
default. The smoke test app floats to current testem, which needs
`require(esm)` for execa 9, and to packages whose engines exclude
Node 18.

CI now runs on Node 22, and the smoke test matrices run on 22, 24,
and 26.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.54%. Comparing base (7aafbea) to head (f52b655).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1110   +/-   ##
=======================================
  Coverage   95.54%   95.54%           
=======================================
  Files          21       21           
  Lines         516      516           
=======================================
  Hits          493      493           
  Misses         23       23           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NullVoxPopuli
NullVoxPopuli merged commit 75eed15 into ember-cli:main Nov 12, 2026
31 of 36 checks passed
@github-actions github-actions Bot mentioned this pull request Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants