[Hermes][iOS] Remove RCT_HERMES_V1_ENABLED from CocoaPods infrastructure#56701
Open
cipolleschi wants to merge 4 commits intomainfrom
Open
[Hermes][iOS] Remove RCT_HERMES_V1_ENABLED from CocoaPods infrastructure#56701cipolleschi wants to merge 4 commits intomainfrom
cipolleschi wants to merge 4 commits intomainfrom
Conversation
meta-cla
Bot
added
the
CLA Signed
cipolleschi
changed the title
cipolleschi
changed the base branch from
cipolleschi/remove-legacy-hermes-phase2
to
main
cipolleschi
force-pushed
the
cipolleschi/remove-legacy-hermes-phase3
branch
from
3b672ef to
00d6b46
Compare
Legacy Hermes support is no longer needed since 0.86 branch has been cut. This removes all dead code behind `!defined(HERMES_V1_ENABLED)` guards and the CMake infrastructure that set the HERMES_V1_ENABLED compile definition.
…solution Since legacy Hermes is no longer supported, remove the hermesV1Enabled toggle from the Gradle plugin, version.properties, and all build scripts. HERMES_V1_VERSION_NAME is renamed to HERMES_VERSION_NAME as the single Hermes version. CMake flags like HERMESVM_HEAP_HV_MODE are now unconditional.
…solution Since legacy Hermes is no longer supported, remove the hermesV1Enabled toggle from the Gradle plugin, version.properties, and all build scripts. HERMES_V1_VERSION_NAME is renamed to HERMES_VERSION_NAME as the single Hermes version. CMake flags like HERMESVM_HEAP_HV_MODE are now unconditional.
cipolleschi
force-pushed
the
cipolleschi/remove-legacy-hermes-phase3
branch
from
00d6b46 to
c491566
Compare
Remove the RCT_HERMES_V1_ENABLED environment variable and all conditional logic in the CocoaPods/Ruby files. The podspec now always reads HERMES_VERSION_NAME, uses V1 source files, and omits legacy inspector subspecs. The HERMES_V1_ENABLED=1 preprocessor define is no longer set since no C++ code checks for it.
cipolleschi
force-pushed
the
cipolleschi/remove-legacy-hermes-phase3
branch
from
c491566 to
cdcd377
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D104247277. |
cortinico
approved these changes
May 7, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RCT_HERMES_V1_ENABLEDenvironment variable fromreact_native_pods.rbjsengine.rbto always use.hermesversiontag fileHERMES_V1_ENABLED=1preprocessor definition fromutils.rbhermes-engine.podspec: always readHERMES_VERSION_NAME, use V1 source files, remove legacy inspector subspecshermes-utils.rb: removehermes_v1_enabled()function, always use250829098.0.0-stablebranch, always use.hermesversiontag filePrev PR: #56700
Next PR: #56703
Changelog:
[iOS][Removed] - Remove the RCT_HERMES_V1_ENABLED from Cocoapods
Test plan
bundle exec pod install— successxcodebuildrn-tester on iPhone 16 Pro simulator — BUILD SUCCEEDED