[Hermes][JS] Consolidate Hermes version files and simplify JS release scripts#56703
Draft
cipolleschi wants to merge 4 commits intomainfrom
Draft
[Hermes][JS] Consolidate Hermes version files and simplify JS release scripts#56703cipolleschi wants to merge 4 commits intomainfrom
cipolleschi wants to merge 4 commits intomainfrom
Conversation
meta-cla
Bot
added
the
CLA Signed
|
Caution Invalid Base Branch The base branch for this PR is |
cipolleschi
changed the title
Legacy Hermes support is no longer needed since 0.86 branch has been cut. This removes all dead code behind `!defined(HERMES_V1_ENABLED)` guards and the CMake infrastructure that set the HERMES_V1_ENABLED compile definition.
…solution Since legacy Hermes is no longer supported, remove the hermesV1Enabled toggle from the Gradle plugin, version.properties, and all build scripts. HERMES_V1_VERSION_NAME is renamed to HERMES_VERSION_NAME as the single Hermes version. CMake flags like HERMESVM_HEAP_HV_MODE are now unconditional.
Remove the RCT_HERMES_V1_ENABLED environment variable and all conditional logic in the CocoaPods/Ruby files. The podspec now always reads HERMES_VERSION_NAME, uses V1 source files, and omits legacy inspector subspecs. The HERMES_V1_ENABLED=1 preprocessor define is no longer set since no C++ code checks for it.
cipolleschi
force-pushed
the
cipolleschi/remove-legacy-hermes-phase3
branch
from
3b672ef to
00d6b46
Compare
Remove dual .hermesversion/.hermesv1version tag files — only .hermesversion remains. Simplify hermes-utils.js to single-tag operations, release scripts to single-version workflows, and bump-hermes-version.js to single Hermes. Remove legacy branch handling from release-hermes-for-branch-cut.js.
cipolleschi
force-pushed
the
cipolleschi/remove-legacy-hermes-phase4
branch
from
78b163f to
0d69970
Compare
This was referenced May 7, 2026
cipolleschi
changed the base branch from
cipolleschi/remove-legacy-hermes-phase3
to
main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sdks/.hermesv1versionfrompackage.jsonfiles array — only.hermesversionremainshermes-utils.js: removereadHermesV1Tag(),HERMES_V1_TAG_FILE_PATH;setHermesTag()takes single argumentscripts/releases/utils/hermes-utils.js: single version ingetLatestHermesNightlyVersion()andupdateHermesRuntimeDependenciesVersions()bump-hermes-version.js: remove--v1-tagand--hermes-v1-versionCLI optionsrelease-hermes-for-branch-cut.js: remove legacy branch/workflow/PR logic, keep only single Hermes branchPrev PR: #56701
Next PR: #56704
Changelog:
[General][Changed] - Simplified build JS Hermes infrastructure for the Release
Test plan
yarn jest --no-watchman hermes-utils-test.js— 5/5 tests pass