Skip to content

meta: Use Craft's built-in post-release version bump - #4605

Merged
BYK merged 1 commit into
masterfrom
meta/use-post-release-bump
Nov 2, 2026
Merged

BYK merged 1 commit into
masterfrom
meta/use-post-release-bump

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Craft 3.7.0 can set master back to a development version after a release (postReleaseBump). This replaces scripts/post-release.sh with postReleaseBump: { version: nightly }.

  • Craft runs the existing bash scripts/bump-version.sh with CRAFT_NEW_VERSION=nightly, the same thing the script did, then commits and pushes. This is a release-tooling change; operators aren't affected.
  • The commit message changes from build: Set master version to nightly to Craft's meta: Bump new development version (still #skip-changelog).
  • minVersion goes to 3.7.0. prepare uses getsentry/craft@v3 (now 3.7.0), and publish runs getsentry/craft:latest.
  • AGENTS.md and the bump-version.sh comment no longer mention the deleted script.

I checked the config against Craft 3.7.0's schema; it resolves the dev version to nightly. I didn't run the install or unit tests, since the change doesn't touch install paths.

This is a draft because this repo's AGENTS.md asks the person opening a PR to write its description themselves.

via @BYK.

--

View Session in Sentry

Craft 3.7.0 can bump to the next development version after a release
(postReleaseBump), so the hand-written post-release script is no longer
needed.

Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
@BYK
BYK marked this pull request as ready for review November 2, 2026 12:18
@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Coverage Results 📊

✅ 22 passed | Total: 22 | Pass Rate: 100% | Execution Time: 10m 46s

📊 Comparison with Base Branch

Metric Change
Total Tests —
Passed Tests —
Failed Tests —
Skipped Tests —

✨ Test counts unchanged from base.

All tests are passing successfully.

✅ Patch coverage is 100.00% (no changed executable lines found; target 50%).
Project statement coverage is 95.58% (unchanged from base (407bf32) to head (57b6be6)).

Coverage diff
@@            Coverage Diff             @@
##        master     #4605       +/-##
==========================================
  Coverage    95.58%    95.58%        —%
==========================================
  Files            5         5         —
  Tracked lines       339       339         —
  Branches         0         0         —
==========================================
  Hits           324       324         —
  Misses          15        15         —
  Partials         0         0         —

Generated by Coverage Action

@BYK
BYK enabled auto-merge (squash) November 2, 2026 12:20
@BYK
BYK merged commit 0ba08be into master Nov 2, 2026
23 checks passed
@BYK
BYK deleted the meta/use-post-release-bump branch November 2, 2026 12:24

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 57b6be6. Configure here.

Comment thread .craft.yml
preReleaseCommand: bash scripts/bump-version.sh
postReleaseCommand: bash scripts/post-release.sh
postReleaseBump:
version: nightly

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid Craft post-release configuration

High Severity

postReleaseBump and minVersion 3.7.0 replace the working postReleaseCommand plus scripts/post-release.sh, but published Craft (3.6.0 via getsentry/craft@v3 and getsentry/craft:latest) only supports postReleaseCommand. Prepare or publish can fail, or master can stay on the released image tags instead of nightly.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 57b6be6. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant