Skip to content

meta: Use Craft's built-in post-release version bump #4605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BYK merged 1 commit into from
Nov 2, 2026
Merged

meta: Use Craft's built-in post-release version bump #4605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .craft.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
minVersion: 2.21.6
minVersion: 3.7.0
changelogPolicy: auto
preReleaseCommand: bash scripts/bump-version.sh
postReleaseCommand: bash scripts/post-release.sh
postReleaseBump:
version: nightly

@cursor cursor Bot Nov 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid Craft post-release configuration

High Severity

postReleaseBump and minVersion 3.7.0 replace the working postReleaseCommand plus scripts/post-release.sh, but published Craft (3.6.0 via getsentry/craft@v3 and getsentry/craft:latest) only supports postReleaseCommand. Prepare or publish can fail, or master can stay on the released image tags instead of nightly.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 57b6be6. Configure here.

artifactProvider:
name: none
targets:
Expand Down
2 changes: 1 addition & 1 deletion AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ AI assistance is welcome, but the human opening the PR is responsible for the di
## Downstream Consumers and Release Tooling

- `action.yaml` / `get-compose-action/` define the GitHub Action that other Sentry repos use to run self-hosted E2E tests against their own images (relay, snuba, symbolicator, taskbroker, uptime-checker, vroom). Its inputs (`project_name`, `image_url`, `compose_profiles`, `skip_backup_restore_test`, …) are a public interface — do not rename or remove inputs without coordinating with those consumers, and keep default behavior backward compatible.
- Releases are driven by [Craft](https://github.com/getsentry/craft) via `.craft.yml` (calver versioning): Craft runs `scripts/bump-version.sh` pre-release and `scripts/post-release.sh` post-release, and generates `CHANGELOG.md`. Do NOT hand-edit `CHANGELOG.md`, invoke those scripts manually, or hand-bump the `*_IMAGE` tags in `.env` — versioning belongs to the release pipeline.
- Releases are driven by [Craft](https://github.com/getsentry/craft) via `.craft.yml` (calver versioning): Craft runs `scripts/bump-version.sh` to set the release version, runs it again after publishing to set `master` back to `nightly` (`postReleaseBump`), and generates `CHANGELOG.md`. Do NOT hand-edit `CHANGELOG.md`, invoke that script manually, or hand-bump the `*_IMAGE` tags in `.env` — versioning belongs to the release pipeline.

## Where Changes Belong

Expand Down
2 changes: 1 addition & 1 deletion scripts/bump-version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
set -eu

# Craft passes versions via env vars (preferred) with positional args as fallback
# for manual invocation (e.g. post-release.sh calls this with positional args).
# for manual invocation.
OLD_VERSION="${CRAFT_OLD_VERSION:-${1:-}}"
NEW_VERSION="${CRAFT_NEW_VERSION:-${2:-}}"

Expand Down
7 changes: 0 additions & 7 deletions scripts/post-release.sh
View file
Open in desktop

This file was deleted.

Loading