Repository navigation
Conversation
Podman's `volume create` takes the name as a positional argument and has no --name flag, so the volume swap in upgrade-postgres.sh aborted with exit 125 after the old sentry-postgres volume was already removed. Docker accepts the positional form too. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
aminvakil
suggested changes
Nov 5, 2026
aminvakil
left a comment
aminvakil
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for fixing this for podman environments, please remove the unit test, it's unnecessary.
aminvakil
approved these changes
Nov 5, 2026
aldy505
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4567
install/upgrade-postgres.shcreates the replacement volume withvolume create --name sentry-postgresin both the 9.6 → 14 and 14 → 18 branches. Podman'svolume createhas no--nameflag (the name is positional), so on Podman the command exits 125 right aftervolume rm sentry-postgres, leaving the upgraded data only insentry-postgres-new.This switches both places to the positional form
volume create sentry-postgres, which Docker and Podman both accept.A new
_unit-test/upgrade-postgres-volume-create-test.shstubs the container engine so thatvolume create --namefails the way Podman does, runs the 14 → 18 branch and asserts the positional form is used. It fails on master (exit 125) and passes with the change.This change was prepared with help from an AI coding assistant (Claude Code).
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.